-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[android]: fix bridgeless configuration to include DebuggingOverlay in react packages #43661
Conversation
This pull request was exported from Phabricator. Differential Revision: D55375350 |
This pull request was exported from Phabricator. Differential Revision: D55375350 |
…y in react packages (facebook#43661) Summary: Pull Request resolved: facebook#43661 # Changelog: [Internal] 1. Move `BridgelessDebugReactPackage.java` to core, this was added in D43407534. 2. `ReactInstanceJava` to add `BridgelessDebugReactPackage`, so `DebuggingOverlay` view manager will be included in the bridgeless build. 3. Fix `RNTesterApplication.kt` to NOT create `MyLegacyViewManager` for every possible viewManagerName, apart from `"RNTMyNativeView"`, return null instead. Differential Revision: D55375350
This pull request was exported from Phabricator. Differential Revision: D55375350 |
…y in react packages (facebook#43661) Summary: Pull Request resolved: facebook#43661 # Changelog: [Internal] 1. Move `BridgelessDebugReactPackage.java` to core, this was added in D43407534. 2. `ReactInstanceJava` to add `BridgelessDebugReactPackage`, so `DebuggingOverlay` view manager will be included in the bridgeless build. 3. Fix `RNTesterApplication.kt` to NOT create `MyLegacyViewManager` for every possible viewManagerName, apart from `"RNTMyNativeView"`, return null instead. Differential Revision: D55375350
…y in react packages (facebook#43661) Summary: Pull Request resolved: facebook#43661 # Changelog: [Internal] 1. Move `BridgelessDebugReactPackage.java` to core, this was added in D43407534. 2. `ReactInstanceJava` to add `BridgelessDebugReactPackage`, so `DebuggingOverlay` view manager will be included in the bridgeless build. 3. Fix `RNTesterApplication.kt` to NOT create `MyLegacyViewManager` for every possible viewManagerName, apart from `"RNTMyNativeView"`, return null instead. Differential Revision: D55375350
This pull request was exported from Phabricator. Differential Revision: D55375350 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D55375350 |
…y in react packages (facebook#43661) Summary: Pull Request resolved: facebook#43661 # Changelog: [Internal] 1. Move `BridgelessDebugReactPackage.java` to core, this was added in D43407534. 2. `ReactInstanceJava` to add `BridgelessDebugReactPackage`, so `DebuggingOverlay` view manager will be included in the bridgeless build. 3. Fix `RNTesterApplication.kt` to NOT create `MyLegacyViewManager` for every possible viewManagerName, apart from `"RNTMyNativeView"`, return null instead. Differential Revision: D55375350
…y in react packages (facebook#43661) Summary: # Changelog: [Internal] 1. Remove `BridgelessDebugReactPackage.java` to core, this was added in D43407534. Technically, its the same as `DebugCorePackage.java`. 2. `ReactInstance` to add `DebugCorePackage`, so `DebuggingOverlay` view manager will be included in the bridgeless build. 3. Fix `RNTesterApplication.kt` to NOT create `MyLegacyViewManager` for every possible viewManagerName, apart from `"RNTMyNativeView"`, return null instead. Differential Revision: D55375350
This pull request was exported from Phabricator. Differential Revision: D55375350 |
…y in react packages (facebook#43661) Summary: # Changelog: [Internal] 1. Remove `BridgelessDebugReactPackage.java` to core, this was added in D43407534. Technically, its the same as `DebugCorePackage.java`. 2. `ReactInstance` to add `DebugCorePackage`, so `DebuggingOverlay` view manager will be included in the bridgeless build. 3. Fix `RNTesterApplication.kt` to NOT create `MyLegacyViewManager` for every possible viewManagerName, apart from `"RNTMyNativeView"`, return null instead. Differential Revision: D55375350
This pull request was exported from Phabricator. Differential Revision: D55375350 |
…y in react packages (facebook#43661) Summary: # Changelog: [Internal] 1. Remove `BridgelessDebugReactPackage.java`, this was added in D43407534. Technically, its the same as `DebugCorePackage.java`. 2. `ReactInstance` to add `DebugCorePackage`, so `DebuggingOverlay` view manager will be included in the bridgeless build. 3. Fix `RNTesterApplication.kt` to NOT create `MyLegacyViewManager` for every possible viewManagerName, apart from `"RNTMyNativeView"`, return null instead. Differential Revision: D55375350
This pull request was exported from Phabricator. Differential Revision: D55375350 |
Base commit: 575507d |
This pull request has been merged in ad93680. |
…y in react packages (#43661) Summary: Pull Request resolved: #43661 # Changelog: [Internal] 1. Remove `BridgelessDebugReactPackage.java`, this was added in D43407534. Technically, its the same as `DebugCorePackage.java`. 2. `ReactInstance` to add `DebugCorePackage`, so `DebuggingOverlay` view manager will be included in the bridgeless build. 3. Fix `RNTesterApplication.kt` to NOT create `MyLegacyViewManager` for every possible viewManagerName, apart from `"RNTMyNativeView"`, return null instead. Reviewed By: cortinico Differential Revision: D55375350 fbshipit-source-id: 1d3cb6b5ad3c0248df1def9f37c8c49b308f4473
Summary:
Changelog: [Internal]
BridgelessDebugReactPackage.java
to core, this was added in D43407534.ReactInstanceJava
to addBridgelessDebugReactPackage
, soDebuggingOverlay
view manager will be included in the bridgeless build.RNTesterApplication.kt
to NOT createMyLegacyViewManager
for every possible viewManagerName, apart from"RNTMyNativeView"
, return null instead.Differential Revision: D55375350