Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rn][ios][0.74][RC6] decouple RCTBridge+Private from jsinspector-modern #43708

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

philIip
Copy link
Contributor

@philIip philIip commented Mar 29, 2024

Changelog: [Internal]

Summary

new debugger logic added in 0.74 implicitly imported a C++ library depending on boost into the public headers for anyone importing RCTBridge+Private, which is a common header imported by libraries. boost is hard to link correctly, so this has caused issues with libraries such as OP-SQLite (#43204).

this must be picked directly against 0.74 instead of off master because PageTarget was renamed to HostTarget after the 0.74 cut.

do not pick into master!!!

Test Plan

build passes

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 29, 2024
@analysis-bot
Copy link

analysis-bot commented Mar 29, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,820,386 -1,056,580
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,178,700 -1,071,322
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: f7ec469
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants