fix fetch memory leak #44336
Closed
fix fetch memory leak #44336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This PR addresses issues #39100 #43647. @cortinico PTAL |
huzhanbo1996
force-pushed
the
p/huzhanbo/fixBlobLeak
branch
from
21ec3cb to
005db2f
Compare
Base commit: 0383669 |
| @@ -21,7 +21,7 @@ static void install(final ReactContext reactContext, final BlobModule blobModule | |||
| new Runnable() { | |||
| @Override | |||
| public void run() { | |||
| JavaScriptContextHolder jsContext = reactContext.getJavaScriptContextHolder(); | |||
| JavaScriptContextHolder jsContext = reactContext.getCatalystInstance().getJavaScriptContextHolder(); | |||
There was a problem hiding this comment.
This change might not be needed past #44360
There was a problem hiding this comment.
@arushikesarwani94 Hi, PTAL again at the changes.
huzhanbo1996
force-pushed
the
p/huzhanbo/fixBlobLeak
branch
from
005db2f to
d1c98dd
Compare
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @NickGerleman, some facebook internal Lint/Check failed. Could you give me some guide to fix them? |
|
@NickGerleman merged this pull request in c647950. |
|
This pull request was successfully merged by huzhanbo.luc in c647950. When will my fix make it into a release? | How to file a pick request? |
|
nice, waiting for this improvement! |
|
how about using libs fetching api like |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Root cause of the fetch memory leak: The fetch requests store its result inside Blob which memory is managed by BlobCollector. On the JS engine side, the Blob is represented by an ID as JS string, and the GC don't know the size of the blob. So GC won't have interests to release the Blob. Fix: On iOS and Android, use `setExternalMemoryPressure` to acknowledge JS engine the size of Blob it holds. ## Changelog: [GENERAL] [FIXED] - fix fetch memory leak Pull Request resolved: facebook#44336 Test Plan: `RepeatedlyFetch` inside `XHR` example Reviewed By: javache Differential Revision: D57145270 Pulled By: NickGerleman fbshipit-source-id: afa53540e8563db4f9c6657f2dbbdff7bdfa66c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Root cause of the fetch memory leak:
The fetch requests store its result inside Blob which memory is managed by BlobCollector. On the JS engine side,
the Blob is represented by an ID as JS string, and the GC don't know the size of the blob. So GC won't have interests to release the Blob.
Fix:
On iOS and Android, use
setExternalMemoryPressureto acknowledge JS engine the size of Blob it holds.Changelog:
[GENERAL] [FIXED] - fix fetch memory leak
Test Plan:
RepeatedlyFetchinsideXHRexample