Make text wrap examples not rely on the RNTester window width #44505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57166025 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 9, 2024
…ok#44505) Summary: # Changelist: [Internal] - The RNTester/Text tests, that are related to text wrapping (such as "wrap mode", "ellipsize", "numberOfLines" ones) were written with the mobile form factor in mind, whereas the RNTester window is generally expected to be narrow and tall. Now, that we are running on other platforms as well, there is no guarantee about the RNTester window width, in general, so these tests relying on particular window width is not practical anymore. This makes the corresponding tests work in a useful way without making assumptions about the RNTester's window width. Differential Revision: D57166025
|
This pull request was exported from Phabricator. Differential Revision: D57166025 |
…ok#44505) Summary: # Changelist: [Internal] - The RNTester/Text tests, that are related to text wrapping (such as "wrap mode", "hyphenation", "ellipsize", "numberOfLines" ones) were written with the mobile form factor in mind, whereas the RNTester window is generally expected to be narrow and tall. Now, that we are running on other platforms as well, there is no guarantee about the RNTester window width, in general, so these tests relying on particular window width is not practical anymore. This makes the corresponding tests work in a useful way without making assumptions about the RNTester's window width. Differential Revision: D57166025
|
This pull request was exported from Phabricator. Differential Revision: D57166025 |
|
This pull request has been merged in f4996e0. |
|
This pull request was successfully merged by @rshest in f4996e0. When will my fix make it into a release? | How to file a pick request? |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 10, 2024
Summary: # Changelog: [Internal] - A follow-up to facebook#44505, turns out this is also an issue for TextInput examples, which work of assumption of some of the text input fields being of limited width, but in practice growing to occupy the parent window width, which can be quite large on platforms different from the classic mobile ones. This diff makes the corresponding tests more practical, not expanding to the parent window anymore. Differential Revision: D57196308
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 10, 2024
…ook#44517) Summary: # Changelog: [Internal] - A follow-up to facebook#44505, turns out this is also an issue for TextInput examples, which work of assumption of some of the text input fields being of limited width, but in practice growing to occupy the parent window width, which can be quite large on platforms different from the classic mobile ones. This diff makes the corresponding tests more practical, not expanding to the parent window anymore. Differential Revision: D57196308
facebook-github-bot
pushed a commit
that referenced
this pull request
May 10, 2024
Summary: Pull Request resolved: #44517 # Changelog: [Internal] - A follow-up to #44505, turns out this is also an issue for TextInput examples, which work of assumption of some of the text input fields being of limited width, but in practice growing to occupy the parent window width, which can be quite large on platforms different from the classic mobile ones. This diff makes the corresponding tests more practical, not expanding to the parent window anymore. Reviewed By: christophpurrer Differential Revision: D57196308 fbshipit-source-id: 7018e8c51adb70fe6a03e50d71eff9ba997fd07a
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…ok#44505) Summary: Pull Request resolved: facebook#44505 # Changelog: [Internal] - The RNTester/Text tests, that are related to text wrapping (such as "wrap mode", "hyphenation", "ellipsize", "numberOfLines" ones) were written with the mobile form factor in mind, whereas the RNTester window is generally expected to be narrow and tall. Now, that we are running on other platforms as well, there is no guarantee about the RNTester window width, in general, so these tests relying on particular window width is not practical anymore. This makes the corresponding tests work in a useful way without making assumptions about the RNTester's window width. Differential Revision: D57166025 fbshipit-source-id: 3305a31f7ca254d82c85d67c975c1140050adc28
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…ook#44517) Summary: Pull Request resolved: facebook#44517 # Changelog: [Internal] - A follow-up to facebook#44505, turns out this is also an issue for TextInput examples, which work of assumption of some of the text input fields being of limited width, but in practice growing to occupy the parent window width, which can be quite large on platforms different from the classic mobile ones. This diff makes the corresponding tests more practical, not expanding to the parent window anymore. Reviewed By: christophpurrer Differential Revision: D57196308 fbshipit-source-id: 7018e8c51adb70fe6a03e50d71eff9ba997fd07a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelist:
[Internal] -
The RNTester/Text tests, that are related to text wrapping (such as "wrap mode", "ellipsize", "numberOfLines" ones) were written with the mobile form factor in mind, whereas the RNTester window is generally expected to be narrow and tall.
Now, that we are running on other platforms as well, there is no guarantee about the RNTester window width, in general, so these tests relying on particular window width is not practical anymore.
This makes the corresponding tests work in a useful way without making assumptions about the RNTester's window width.
Differential Revision: D57166025