Migrate NativeArray classes to Kotlin #44569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57327835 |
|
This pull request was exported from Phabricator. Differential Revision: D57327835 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 15, 2024
Summary: Pull Request resolved: facebook#44569 # Changelog: [Internal] - This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. NOTE: the `getArray`, `getMap` and `getString` being annotated as `NonNull` in the Java code is a scam - there is no guarantee that native side will send non-null to the Java side, and in practice, indeed, in certain cases it doesn't. So I opted to make it nullable instead - this way it's at least explicit and is not a ticking bomb hidden to explode behind the false sense of security. Differential Revision: D57327835
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 15, 2024
Summary: Pull Request resolved: facebook#44569 # Changelog: [Internal] - This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. Differential Revision: https://internalfb.com/D57327835
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 15, 2024
Summary: Pull Request resolved: facebook#44569 # Changelog: [Internal] - This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. Differential Revision: https://internalfb.com/D57327835
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 15, 2024
Summary: Pull Request resolved: facebook#44569 # Changelog: [Internal] - This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. NOTE: the `getArray`, `getMap` and `getString` being annotated as `NonNull` in the Java code is a scam - there is no guarantee that native side will send non-null to the Java side, and in practice, indeed, in certain cases it doesn't. So I opted to make it nullable instead - this way it's at least explicit and is not a ticking bomb hidden to explode behind the false sense of security. Differential Revision: https://internalfb.com/D57327835
|
This pull request was exported from Phabricator. Differential Revision: D57327835 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 15, 2024
Summary: Pull Request resolved: facebook#44569 # Changelog: [Internal] - This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. NOTE: the `getArray`, `getMap` and `getString` being annotated as `NonNull` in the Java code is a scam - there is no guarantee that native side will send non-null to the Java side, and in practice, indeed, in certain cases it doesn't. So I opted to make it nullable instead - this way it's at least explicit and is not a ticking bomb hidden to explode behind the false sense of security. Differential Revision: D57327835
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 15, 2024
Summary: Pull Request resolved: facebook#44569 # Changelog: [Internal] - This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. NOTE: the `getArray`, `getMap` and `getString` being annotated as `NonNull` in the Java code is a scam - there is no guarantee that native side will send non-null to the Java side, and in practice, indeed, in certain cases it doesn't. So I opted to make it nullable instead - this way it's at least explicit and is not a ticking bomb hidden to explode behind the false sense of security. Differential Revision: https://internalfb.com/D57327835
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 15, 2024
Summary: Pull Request resolved: facebook#44569 # Changelog: [Internal] - This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. NOTE: the `getArray`, `getMap` and `getString` being annotated as `NonNull` in the Java code is a scam - there is no guarantee that native side will send non-null to the Java side, and in practice, indeed, in certain cases it doesn't. So I opted to make it nullable instead - this way it's at least explicit and is not a ticking bomb hidden to explode behind the false sense of security. Differential Revision: https://internalfb.com/D57327835
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 15, 2024
Summary: Pull Request resolved: facebook#44569 # Changelog: [Internal] - This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. NOTE: the `getArray`, `getMap` and `getString` being annotated as `NonNull` in the Java code is a scam - there is no guarantee that native side will send non-null to the Java side, and in practice, indeed, in certain cases it doesn't. So I opted to make it nullable instead - this way it's at least explicit and is not a ticking bomb hidden to explode behind the false sense of security. Differential Revision: https://internalfb.com/D57327835
rshest
added a commit
to rshest/react-native
that referenced
this pull request
May 15, 2024
Summary: Pull Request resolved: facebook#44569 # Changelog: [Internal] - This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. NOTE: the `getArray`, `getMap` and `getString` being annotated as `NonNull` in the Java code is a scam - there is no guarantee that native side will send non-null to the Java side, and in practice, indeed, in certain cases it doesn't. So I opted to make it nullable instead - this way it's at least explicit and is not a ticking bomb hidden to explode behind the false sense of security. Differential Revision: https://internalfb.com/D57327835
|
This pull request was exported from Phabricator. Differential Revision: D57327835 |
rshest
force-pushed
the
export-D57327835
branch
from
c713cb2 to
998e654
Compare
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 2, 2024
Summary: Pull Request resolved: facebook#44569 # Changelog: [Internal] - This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. NOTE: the `getArray`, `getMap` and `getString` being annotated as `NonNull` in the Java code is a scam - there is no guarantee that native side will send non-null to the Java side, and in practice, indeed, in certain cases it doesn't. So I opted to make it nullable instead - this way it's at least explicit and is not a ticking bomb hidden to explode behind the false sense of security. Reviewed By: javache Differential Revision: D57327835
|
This pull request was exported from Phabricator. Differential Revision: D57327835 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 2, 2024
Summary: Pull Request resolved: facebook#44569 # Changelog: [Internal] - This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. NOTE: the `getArray`, `getMap` and `getString` being annotated as `NonNull` in the Java code is a scam - there is no guarantee that native side will send non-null to the Java side, and in practice, indeed, in certain cases it doesn't. So I opted to make it nullable instead - this way it's at least explicit and is not a ticking bomb hidden to explode behind the false sense of security. Reviewed By: javache Differential Revision: D57327835
rshest
force-pushed
the
export-D57327835
branch
from
998e654 to
c0f52b8
Compare
Summary: Pull Request resolved: facebook#44569 # Changelog: [Internal] - This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. NOTE: the `getArray`, `getMap` and `getString` being annotated as `NonNull` in the Java code is a scam - there is no guarantee that native side will send non-null to the Java side, and in practice, indeed, in certain cases it doesn't. So I opted to make it nullable instead - this way it's at least explicit and is not a ticking bomb hidden to explode behind the false sense of security. Reviewed By: javache Differential Revision: D57327835
|
This pull request was exported from Phabricator. Differential Revision: D57327835 |
rshest
force-pushed
the
export-D57327835
branch
from
c0f52b8 to
d165515
Compare
|
This pull request has been merged in 878e1f3. |
|
This pull request was successfully merged by @rshest in 878e1f3 When will my fix make it into a release? | How to file a pick request? |
bvanderhoof
pushed a commit
to bvanderhoof/react-native
that referenced
this pull request
Aug 3, 2024
Summary: Pull Request resolved: facebook#44569 Changelog: [Internal] - Reverting this diff due to internal build crashes: This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. Reviewed By: bvanderhoof Differential Revision: D60707170
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 3, 2024
Summary: Pull Request resolved: #45884 Pull Request resolved: #44569 Changelog: [Internal] - Reverting this diff due to internal build crashes: This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin. Reviewed By: bvanderhoof Differential Revision: D60707170 fbshipit-source-id: 95e66ebe725d0ff625b50f4711872b9f70ec2f7c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
This converts the vertical of NativeArray/ReadableNativeArray/WritableNativeArray classes to Kotlin.
Differential Revision: D57327835