-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: warn only in init
command when CLI uses cached npx
version
#44644
fix: warn only in init
command when CLI uses cached npx
version
#44644
Conversation
Also this wasn't visible to anyone because of react-native-community/cli#2389. @blakef I'd appreciate if you can take a look at this PR 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @szymonrybczak!
For some reasons, prettier is failing. Could you have a look at that, please? |
@blakef I think that is a right approach, |
By the way I think it should be also backported to 0.74 along with react-native-community/cli#2389 once released. |
@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @szymonrybczak in b98c5b9. When will my fix make it into a release? | How to file a pick request? |
…44644) Summary: In #37510, a check was introduced to check if user is using `latest` version of `npx`, but right now it checks for every command executed, but it should only ensure that `latest` is included when creating a new project. In this Pull Request I've added a condition to only warn if `init` was fired. [GENERAL] [FIXED] - Warn only in `init` command when CLI uses cached `npx` version Pull Request resolved: #44644 Test Plan: Warning about using `latest` version CLI should only be presented when running `init` command. Reviewed By: arushikesarwani94 Differential Revision: D57681864 Pulled By: blakef fbshipit-source-id: 5c81b9a08141396efcd24539b2560cea16028dd9
…acebook#44644) Summary: In facebook#37510, a check was introduced to check if user is using `latest` version of `npx`, but right now it checks for every command executed, but it should only ensure that `latest` is included when creating a new project. In this Pull Request I've added a condition to only warn if `init` was fired. ## Changelog: [GENERAL] [FIXED] - Warn only in `init` command when CLI uses cached `npx` version Pull Request resolved: facebook#44644 Test Plan: Warning about using `latest` version CLI should only be presented when running `init` command. Reviewed By: arushikesarwani94 Differential Revision: D57681864 Pulled By: blakef fbshipit-source-id: 5c81b9a08141396efcd24539b2560cea16028dd9
Summary:
In #37510, a check was introduced to check if user is using
@latest
version ofnpx
, but right now it checks for every command executed, but it should only ensure that@latest
is included when creating a new project.In this Pull Request I've added a condition to only warn if
init
was fired.Changelog:
[GENERAL] [FIXED] - Warn only in
init
command when CLI uses cachednpx
versionTest Plan:
Warning about using
@latest
version CLI should only be presented when runninginit
command.