Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hermes prepare_command fails with space in path #45316

Closed

Conversation

okwasniewski
Copy link
Contributor

Summary:

This PR fixes a case where the user initializes react native in a directory that contains a space.

It was causing pod install to fail because the path to create-dummy-hermes-xcframework.sh script wasn't in a string.

Changelog:

[IOS] [FIXED] - Hermes prepare_command fails with space in path

Test Plan:

  1. Create a directory with space in path
  2. Initialize React Native inside
  3. Install pods
  4. Check if pod install doesn't fail

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner labels Jul 8, 2024
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jul 8, 2024
@okwasniewski
Copy link
Contributor Author

Hey @cipolleschi can you take a look at this? It's a small fix

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @okwasniewski for the fix!

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in fbcb8f6.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 18, 2024
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @okwasniewski in fbcb8f6

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants