Enable third-party podspec sources to be fetched from mirrored git repositories

[RailByteOEBB]

Summary:

At OEBB we currently facing an issue we're not able to use our mirrored git repositories for third-party podspecs. This is due to the fact podspecs contain hardcoded git repository urls. With this change we could specify urls to our mirrored git repositories.

Changelog:

[IOS] [ADDED] Enable third-party podspec sources to be fetched from mirrored git repositories

Test Plan:

# Define env vars for git mirrors

export FMT_GIT_URL="https://my-git-host.com/my-mirrored-repo.git"
export GLOG_GIT_URL="https://my-git-host.com/my-mirrored-repo.git"
export FOLLY_GIT_URL="https://my-git-host.com/my-mirrored-repo.git"
export DOUBLE_CONVERSION_GIT_URL="https://my-git-host.com/my-mirrored-repo.git"
export BOOST_GIT_URL="https://my-git-host.com/my-mirrored-repo.git"

# Pod install command run from ios app folder 
pod install

[cipolleschi]

Hi @RailByteOEBB, thanks for the proposal.
I do understand your use case, but I don't really like the idea of having those ENV var spread across the codebase.

I think that it would be better if we find a different way to handle this.

one way to go could be:

• from the react_native_pods.rb file, we export a function that returns the repository given the name of the pod
• the pods consume that function, so the code is clean and polished
• we find a way to define those mirrors in the Podfile, so there is no need for environment variables.
  what do you think?

[RailByteOEBB]

Hi @cipolleschi, thanks for your quick response.

I would propose the following solution:

• Adding default values foreach third party dependency in helpers.rb as it's currently done with folly. E.g Helpers::Constants.folly_config
• Adding getter and setter functions to react_native_pods.rb similar to current existing solution for folly get_folly_config .
  • The setter function would override the specified default values in helpers.rb
• The setter function would be callable from podfile of the application. One could override it like set_glog_config(mirrored_url)

What do you think?

[cipolleschi]

@RailByteOEBB sorry for the late reply!
Yep, the approach can work, if you are up for the changes, we can then test them and upstream them.

[RailByteOEBB]

Hi @cipolleschi,

thanks for your reply. I've implemented the changes. May I ask you to review it again?

[cipolleschi]

great job, thanks for working on it.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi merged this pull request in 53969cb.

[react-native-bot]

This pull request was successfully merged by @RailByteOEBB in 53969cb

^{When will my fix make it into a release? | How to file a pick request?}