fix: add missing submitBehavior
prop type and mark blurOnSubmit
prop as deprecated in typescript declaration file of TextInput
#45588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Hi, I just found out that #33653 adds a new prop in
TextInput
that enables multilineTextInput
be able to submit without blurring.It does that by adding a new prop called
submitBehavior
which accepts'submit' | 'blurAndSubmit' | 'newline'
:react-native/packages/react-native/Libraries/Components/TextInput/TextInput.js
Line 195 in 700b403
react-native/packages/react-native/Libraries/Components/TextInput/TextInput.js
Lines 910 to 928 in 700b403
It also marks
blurOnSubmit
prop as deprecated since it can now be handled fromsubmitBehavior
:react-native/packages/react-native/Libraries/Components/TextInput/TextInput.js
Lines 896 to 908 in 700b403
However, that PR doesn't update
TextInput.d.ts
file which results Typescript to complain that the type doesn't exist:So this PR adds and updates the types in declaration file to support them in Typescript
Changelog:
[GENERAL] [FIXED] - add missing
submitBehavior
prop and markblurOnSubmit
prop as deprecated in Typescript declaration file ofTextInput
Test Plan:
Before:
After: