Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOCAL] Make rrc_textinput on Android a shared library #45592

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[LOCAL] Make rrc_textinput on Android a shared library #45592

merged 1 commit into from
Jul 29, 2024

Conversation

j-piasecki
Copy link
Collaborator

Summary:

Making rrc_textinput allows other libraries (namely react-native-live-markdown) to rely on types related to text inputs on Android. Currently, with static linking, type information is duplicated causing dynamic_casts to fail.

Changelog:

[ANDROID] [CHANGED] - Change rrc_textinput to be a dynamic library

Test Plan:

Run RNTester and see that everything works as before

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 23, 2024
@cortinico
Copy link
Contributor

@j-piasecki I think we won't be merging this as we're going in the opposite direction of having a single libreactnative.so library.

@j-piasecki j-piasecki changed the base branch from main to 0.75-stable July 23, 2024 10:34
@j-piasecki j-piasecki force-pushed the @jpiasecki/make-rrc_textinput-shared branch from 9a4d0a0 to 979c13d Compare July 23, 2024 10:36
@j-piasecki j-piasecki mentioned this pull request Jul 23, 2024
Closed
@cortinico cortinico changed the title Make rrc_textinput on Android a shared library [LOCAL] Make rrc_textinput on Android a shared library Jul 23, 2024
@cipolleschi cipolleschi merged commit ea8ad64 into facebook:0.75-stable Jul 29, 2024
80 of 90 checks passed
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,722,515 -632,341
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,921,195 -628,796
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fcd526d
Branch: main

This was referenced Aug 15, 2024
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Sep 2, 2024
Merged
@blakef blakef mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Software Mansion Partner: Software Mansion Partner Pick Request Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@j-piasecki @cortinico @analysis-bot @facebook-github-bot @cipolleschi