Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert modules/core/ReactChoreographer to Kotlin #45811

Closed
wants to merge 2 commits into from

Conversation

rshest
Copy link
Contributor

@rshest rshest commented Jul 30, 2024

Summary:

Changelog:

[Internal] -

Converts both ReactChoreographer.java and ChoreographerCompat.java to Kotlin.

Differential Revision: D60445731

Differential Revision: D60377675
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 30, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60445731

rshest added a commit to rshest/react-native that referenced this pull request Jul 30, 2024
Summary:
Pull Request resolved: facebook#45811

# Changelog:
[Internal] -

Converts both ReactChoreographer.java and ChoreographerCompat.java to Kotlin.

Reviewed By: cortinico

Differential Revision: D60445731
@rshest rshest force-pushed the export-D60445731 branch from 928a42a to ecee38b Compare July 30, 2024 11:01
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60445731

…otlin (facebook#45811)

Summary:
Pull Request resolved: facebook#45811

# Changelog:
[Internal] -

Converts both ReactChoreographer.java and ChoreographerCompat.java to Kotlin.

Reviewed By: cortinico

Differential Revision: D60445731
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60445731

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6742af4.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 31, 2024
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @rshest in 6742af4

When will my fix make it into a release? | How to file a pick request?

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60445731

rshest added a commit to rshest/react-native that referenced this pull request Aug 1, 2024
Summary:
Pull Request resolved: facebook#45811

# Changelog:
[Internal] -

Converts both ReactChoreographer.java and ChoreographerCompat.java to Kotlin.

Reviewed By: mdvacca

Differential Revision: D60445731
rshest added a commit to rshest/react-native that referenced this pull request Aug 1, 2024
Summary:
Pull Request resolved: facebook#45811

# Changelog:
[Internal] -

Converts both ReactChoreographer.java and ChoreographerCompat.java to Kotlin.

Reviewed By: mdvacca

Differential Revision: D60445731
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60445731

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60445731

rshest added a commit to rshest/react-native that referenced this pull request Aug 1, 2024
Summary:
Pull Request resolved: facebook#45811

# Changelog:
[Internal] -

Converts both ReactChoreographer.java and ChoreographerCompat.java to Kotlin.

Reviewed By: mdvacca

Differential Revision: D60445731
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60445731

rshest added a commit to rshest/react-native that referenced this pull request Aug 1, 2024
Summary:
Pull Request resolved: facebook#45811

# Changelog:
[Internal] -

Converts both ReactChoreographer.java and ChoreographerCompat.java to Kotlin.

Reviewed By: mdvacca

Differential Revision: D60445731
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60445731

rshest added a commit to rshest/react-native that referenced this pull request Aug 1, 2024
Summary:
Pull Request resolved: facebook#45811

# Changelog:
[Internal] -

Converts both ReactChoreographer.java and ChoreographerCompat.java to Kotlin.

Reviewed By: mdvacca

Differential Revision: D60445731
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60445731

rshest added a commit to rshest/react-native that referenced this pull request Aug 1, 2024
Summary:
Pull Request resolved: facebook#45811

# Changelog:
[Internal] -

Converts both ReactChoreographer.java and ChoreographerCompat.java to Kotlin.

Reviewed By: mdvacca

Differential Revision: D60445731
facebook-github-bot pushed a commit that referenced this pull request Aug 1, 2024
Summary:
Pull Request resolved: #45811

# Changelog:
[Internal] -

Converts both ReactChoreographer.java and ChoreographerCompat.java to Kotlin.

Reviewed By: mdvacca

Differential Revision: D60445731

fbshipit-source-id: 597c9f2ea1a89ee13a210a4b3e172ea239297ae7
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @rshest in 6483a28

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants