Set nativeSourceCodeFetching capability in jsinspector-modern targets #45850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D54496969
…t (Android Bridge) Differential Revision: D60036502
Summary: Following facebook#45664, implements the `networkRequest` method of `jsinspector_modern::HostTargetDelegate` for Android (Bridgeless). Changelog: [Internal] Differential Revision: D60232817
Summary: This fixes a bug where we were calling `delegate.didReceiveMessage` (and other handlers) from multiple threads on Android. In particular, with the addition of `Network.loadNetworkResource` in D54496969, we observed memory access issues in the implementation for `IO.read` in `NetworkIOAgent` after multiple successive requests are received. Changelog: [Internal] Differential Revision: D60520747
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60236216 |
…facebook#45850) Summary: Pull Request resolved: facebook#45850 Enables the `nativeSourceCodeFetching` capability flag for the modern debugger stack on both Android and iOS. This disables source code fetching hacks within the Inspector Proxy layer and instead enables the debugger server to handle all source code fetching directly on the device. Changelog: [Internal] Differential Revision: D60236216
|
This pull request was exported from Phabricator. Differential Revision: D60236216 |
2 tasks
|
This pull request has been merged in 7c49df9. |
kaseywolff
pushed a commit
to kaseywolff/react-native
that referenced
this pull request
Aug 19, 2024
…facebook#45850) Summary: Pull Request resolved: facebook#45850 Enables the `nativeSourceCodeFetching` capability flag for the modern debugger stack on both Android and iOS. This disables source code fetching hacks within the Inspector Proxy layer and instead enables the debugger server to handle all source code fetching directly on the device. Changelog: [Internal] Differential Revision: D60236216 fbshipit-source-id: 1239b4d7d2233852f007114721b202d90459fa06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enables the
nativeSourceCodeFetchingcapability flag for the modern debugger stack on both Android and iOS. This disables source code fetching hacks within the Inspector Proxy layer and instead enables the debugger server to handle all source code fetching directly on the device.Changelog: [Internal]
Differential Revision: D60236216