fix: Hermes build for visionOS simulator (Release) #45911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Aug 6, 2024
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
okwasniewski
force-pushed
the
fix/hermes-visionos-build
branch
from
c2d30b8
to
a87e5ca
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 05dec91. |
|
This pull request was successfully merged by @okwasniewski in 05dec91 When will my fix make it into a release? | How to file a pick request? |
okwasniewski
added a commit
to okwasniewski/react-native
that referenced
this pull request
Aug 22, 2024
Summary: Building for the visionOS simulator in the Release scheme requires an x86_64 slice to be included.  ## Changelog: [IOS] [FIXED] - Include x86_64 slice when building for visionOS simulator Pull Request resolved: facebook#45911 Test Plan: CI Green Reviewed By: GijsWeterings Differential Revision: D60828872 Pulled By: cipolleschi fbshipit-source-id: 74444ac0b6661baf427837d242ba0ca295da0d16
This was referenced Aug 22, 2024
cipolleschi
pushed a commit
that referenced
this pull request
Sep 11, 2024
) (#46169) Summary: Building for the visionOS simulator in the Release scheme requires an x86_64 slice to be included.  ## Changelog: [IOS] [FIXED] - Include x86_64 slice when building for visionOS simulator Pull Request resolved: #45911 Test Plan: CI Green Reviewed By: GijsWeterings Differential Revision: D60828872 Pulled By: cipolleschi fbshipit-source-id: 74444ac0b6661baf427837d242ba0ca295da0d16
|
This pull request was successfully merged by @okwasniewski in 61fdd51. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Building for the visionOS simulator in the Release scheme requires an x86_64 slice to be included.
Changelog:
[IOS] [FIXED] - Include x86_64 slice when building for visionOS simulator
Test Plan:
CI Green