Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back out "Fixes NSDataBigString length calculation" #46011

Closed
wants to merge 1 commit into from
Closed

Back out "Fixes NSDataBigString length calculation" #46011

wants to merge 1 commit into from

Conversation

realsoelynn
Copy link
Contributor

@realsoelynn realsoelynn commented Aug 14, 2024 •
edited
Loading

Changelog: [Internal]
Temporarily revert this diff #44900 while we wait for #45966 to land

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 14, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61246120

@react-native-bot
Copy link
Collaborator

Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 79b5a53

@realsoelynn @facebook-github-bot
Back out "Fixes NSDataBigString length calculation" (facebook#46011)
27cad40 
Summary:
Pull Request resolved: facebook#46011

Backing out D58561775 in the meantime while we are trying to do proper fix in Hermes engine D61058869

Changelog: [Internal]
Temporarily revert this diff facebook#44900 while we wait for facebook#45966 to land

Differential Revision: D61246120
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61246120

@react-native-bot
Copy link
Collaborator

Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 27cad40

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7bb7a60.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 14, 2024
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @realsoelynn in 7bb7a60

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realsoelynn @facebook-github-bot @react-native-bot