Make Filters implicitly set overflow hidden #46145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61630698 |
|
This pull request was exported from Phabricator. Differential Revision: D61630698 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: facebook#46145 Filters clip children by default due to using `RenderEffect` we are keeping this behavior but we were clipping to the border box while Web clips to padding box. To keep the clipping consistent we are enforcing `Overflow.HIDDEN` when a view contains a filter. Differential Revision: D61630698
jorge-cab
force-pushed
the
export-D61630698
branch
from
ac6eeac to
9e870b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61630698 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: facebook#46145 Filters clip children by default due to using `RenderEffect` we are keeping this behavior but we were clipping to the border box while Web clips to padding box. To keep the clipping consistent we are enforcing `Overflow.HIDDEN` when a view contains a filter. Differential Revision: D61630698
jorge-cab
force-pushed
the
export-D61630698
branch
from
9e870b6 to
db6e60b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61630698 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: facebook#46145 Filters clip children by default due to using `RenderEffect` we are keeping this behavior but we were clipping to the border box while Web clips to padding box. To keep the clipping consistent we are enforcing `Overflow.HIDDEN` when a view contains a filter. Differential Revision: D61630698
jorge-cab
force-pushed
the
export-D61630698
branch
from
db6e60b to
45b547a
Compare
Summary: Pull Request resolved: facebook#46145 Filters clip children by default due to using `RenderEffect` we are keeping this behavior but we were clipping to the border box while Web clips to padding box. To keep the clipping consistent we are enforcing `Overflow.HIDDEN` when a view contains a filter. Differential Revision: D61630698
|
This pull request was exported from Phabricator. Differential Revision: D61630698 |
jorge-cab
force-pushed
the
export-D61630698
branch
from
45b547a to
88c06b2
Compare
|
This pull request has been merged in 8618eec. |
|
This pull request was successfully merged by @jorge-cab in 8618eec When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Filters clip children by default due to using
RenderEffectwe are keeping this behavior but we were clipping to the border box while Web clips to padding box.To keep the clipping consistent we are enforcing
Overflow.HIDDENwhen a view contains a filter.Differential Revision: D61630698