Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line offset for baseline alignment of text attachments #46172

Conversation

j-piasecki
Copy link
Collaborator

Summary:

In #45102 I've implemented a baseline alignment function for the new architecture. I've noticed one thing I've missed previously - locationForGlyphAtIndex is relative to the line fragment, not the container. This means that the attachments would be put in the wrong place in multiline text.

This PR fixes that by adding the position of the entire line to the attachment position.

Changelog:

[IOS] [FIXED] - Fixed baseline attachment position in multiline text

Test Plan:

Checked on relevant example of RNTester.

Before After
Screenshot 2024-08-22 at 15 53 14 Screenshot 2024-08-22 at 15 52 37

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 22, 2024
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! Although I can't see the differences between before and after, but that's me! 😅

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 22, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 9bfbf94.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @j-piasecki in 9bfbf94

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants