Reset animatedView when detaching AnimatedProps #46205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When React.Activity unmounts and remounts effects, we fail to re-attach the native view to the NativeAnimated nodes, which causes animations to stop working. Changelog: [Internal] Reviewed By: bvanderhoof Differential Revision: D61662164
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61662164 |
|
This pull request was successfully merged by @javache in fdb77ae When will my fix make it into a release? | How to file a pick request? |
rhagigi
pushed a commit
to rhagigi/react-native
that referenced
this pull request
Sep 11, 2024
…itch Summary: When hiding a view with React.Activity, React will "detach" all the views in teh subtree (call all their effect cleanups) and then upon showing it again will attach them (call all their effects again). This was previously causing problems with useAnimatedProps and facebook#46205 was intended to fix it (cc javache), but it's still a perf drain to have to detach all of this and then re-attach it upon show. Worse, it makes it so that we can't actually do any animations upon re-showing a view until all the passive effects have run to re-attach the views to the animations. So instead, what this diff does is lean on the fact that useInsertionEffect *does not* clean up and rerun when Activity goes from hidden to visible and vice versa. Thus, we can rely on it to only detach the animated node when we're *actually* unmounting - rather than when we're simply hiding/showing. Reviewed By: yungsters, sammy-SC Differential Revision: D62398039
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…itch (#46438) Summary: Pull Request resolved: #46438 When hiding a view with React.Activity, React will "detach" all the views in teh subtree (call all their effect cleanups) and then upon showing it again will attach them (call all their effects again). This was previously causing problems with useAnimatedProps and #46205 was intended to fix it (cc javache), but it's still a perf drain to have to detach all of this and then re-attach it upon show. Worse, it makes it so that we can't actually do any animations upon re-showing a view until all the passive effects have run to re-attach the views to the animations. So instead, what this diff does is lean on the fact that useInsertionEffect *does not* clean up and rerun when Activity goes from hidden to visible and vice versa. Thus, we can rely on it to only detach the animated node when we're *actually* unmounting - rather than when we're simply hiding/showing. Changelog: [General][Changed] - Improved the performance of unmounting (and updating, when an enclosing Activity becomes hidden) Animated components Reviewed By: yungsters, sammy-SC Differential Revision: D62398039 fbshipit-source-id: af286e428188b5104f6cfd3fd4d8c9f791dedb8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When React.Activity unmounts and remounts effects, we fail to re-attach the native view to the NativeAnimated nodes, which causes animations to stop working.
Changelog: [Internal]
Reviewed By: bvanderhoof
Differential Revision: D61662164