Remove incorrect state update during unmount in Modal #46218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [internal] facebook#42975 added some logic to fix modal on iOS for Paper but introduced a state update in `componentWillUnmount`. Doing this is incorrect and we've seen cases where it leads to forcing passive effects synchronously, which can affect performance. This removes that unnecessary call to update the state, because the component will be unmounted anyway. Reviewed By: bgirard Differential Revision: D61813988
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61813988 |
|
This pull request has been merged in 74c9ef8. |
|
This pull request was successfully merged by @rubennorte in 74c9ef8 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
#42975 added some logic to fix modal on iOS for Paper but introduced a state update in
componentWillUnmount. Doing this is incorrect and we've seen cases where it leads to forcing passive effects synchronously, which can affect performance.This removes that unnecessary call to update the state, because the component will be unmounted anyway.
Reviewed By: bgirard
Differential Revision: D61813988