'[skip ci] [codegen] Array'\''s with unparsable element tyoe'\''s are explicitly Any vs missing #46221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61825742 |
|
This pull request was exported from Phabricator. Differential Revision: D61825742 |
elicwhite
added a commit
to elicwhite/react-native
that referenced
this pull request
Aug 27, 2024
… explicitly Any vs missing (facebook#46221) Summary: Pull Request resolved: facebook#46221 Previously the schema special cased unparseable elementType with elementType just being undefined. This causes issues for logic that requires recursively matching types. Instead of being implicit, this makes them explicitly an AnyTypeAnnotation Changelog: [Internal] Differential Revision: D61825742
elicwhite
force-pushed
the
export-D61825742
branch
from
e9475a0 to
2281196
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61825742 |
elicwhite
force-pushed
the
export-D61825742
branch
from
2281196 to
1d86bb1
Compare
elicwhite
added a commit
to elicwhite/react-native
that referenced
this pull request
Aug 27, 2024
…acebook#46221) Summary: Pull Request resolved: facebook#46221 Previously the schema special cased unparseable elementType with elementType just being undefined. This causes issues for logic that requires recursively matching types. Instead of being implicit, this makes them explicitly an AnyTypeAnnotation Changelog: [Internal] Differential Revision: D61825742
elicwhite
added a commit
to elicwhite/react-native
that referenced
this pull request
Aug 28, 2024
… explicitly Any vs missing (facebook#46221) Summary: Pull Request resolved: facebook#46221 Previously the schema special cased unparseable elementType with elementType just being undefined. This causes issues for logic that requires recursively matching types. Instead of being implicit, this makes them explicitly an AnyTypeAnnotation Changelog: [Internal] Reviewed By: makovkastar Differential Revision: D61825742
elicwhite
force-pushed
the
export-D61825742
branch
from
1d86bb1 to
cdca677
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61825742 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D61825742 |
elicwhite
added a commit
to elicwhite/react-native
that referenced
this pull request
Aug 28, 2024
… explicitly Any vs missing (facebook#46221) Summary: Pull Request resolved: facebook#46221 Previously the schema special cased unparseable elementType with elementType just being undefined. This causes issues for logic that requires recursively matching types. Instead of being implicit, this makes them explicitly an AnyTypeAnnotation Changelog: [Internal] Reviewed By: makovkastar Differential Revision: D61825742
elicwhite
force-pushed
the
export-D61825742
branch
from
cdca677 to
60b3308
Compare
elicwhite
added a commit
to elicwhite/react-native
that referenced
this pull request
Aug 28, 2024
…acebook#46221) Summary: Pull Request resolved: facebook#46221 Previously the schema special cased unparseable elementType with elementType just being undefined. This causes issues for logic that requires recursively matching types. Instead of being implicit, this makes them explicitly an AnyTypeAnnotation Changelog: [Internal] Reviewed By: makovkastar Differential Revision: D61825742
elicwhite
force-pushed
the
export-D61825742
branch
from
60b3308 to
dc3377f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61825742 |
…acebook#46221) Summary: Pull Request resolved: facebook#46221 Previously the schema special cased unparseable elementType with elementType just being undefined. This causes issues for logic that requires recursively matching types. Instead of being implicit, this makes them explicitly an AnyTypeAnnotation Changelog: [Internal] Reviewed By: makovkastar Differential Revision: D61825742
elicwhite
force-pushed
the
export-D61825742
branch
from
dc3377f to
7634809
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61825742 |
|
This pull request has been merged in 0b56cca. |
|
This pull request was successfully merged by @TheSavior in 0b56cca When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously the schema special cased unparseable elementType with elementType just being undefined. This causes issues for logic that requires recursively matching types. Instead of being implicit, this makes them explicitly an AnyTypeAnnotation
Differential Revision: D61825742