Fix GH-41226 by suppressing path adjustment when not actually drawing a border #46239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@knappam Can you link the issue and make the title be descriptive of what your change is? |
knappam
changed the title
done, thanks! |
|
@jorge-cab has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jorge-cab
reviewed
Aug 28, 2024
Comment on lines
716
to
719
| mInnerClipTempRectForBorderRadius.left - pathAdjustment; | ||
| mInnerClipTempRectForBorderRadius.top - pathAdjustment; | ||
| mInnerClipTempRectForBorderRadius.right + pathAdjustment; | ||
| mInnerClipTempRectForBorderRadius.bottom + pathAdjustment; |
When not drawing a border, the mGapBetweenPaths adjustment can create noticable pixelation when drawing curves through a low number of pixels. This is noticable mostly on buttons and such on low-dpi devices. This fix only applies the fix if clipping for the border radius is done.
|
@jorge-cab has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jorge-cab merged this pull request in 8501b63. |
|
This pull request was successfully merged by @knappam in 8501b63 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Sep 11, 2024
… a border (#46239) Summary: When not drawing a border, the mGapBetweenPaths adjustment can create noticable pixelation when drawing curves through a low number of pixels. This is noticable mostly on buttons and such on low-dpi devices. This fix only applies the fix if clipping for the border radius is done. When drawing small radius rounded backgrounds (e.g. to draw a circle or button) we see visible pixelation (see [GH-41226](#41226)) This is particularly noticable on low DPI devices. ## Changelog: [ANDROID] [FIXED] - Don't use mGapBetweenPaths if not drawing a border Pull Request resolved: #46239 Test Plan: Built an android app that directly uses CSSBackgroundDrawable to draw a background and verified repro of this issue.  Then modified the code according to this PR and verified that anti-aliasing is appropriately applied  Reviewed By: NickGerleman Differential Revision: D61925281 Pulled By: jorge-cab fbshipit-source-id: 93014629d031bd0d716cd3bb11e2c294dedad639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not drawing a border, the mGapBetweenPaths adjustment can create noticable pixelation when drawing curves through a low number of pixels. This is noticable mostly on buttons and such on low-dpi devices. This fix only applies the fix if clipping for the border radius is done.
Summary:
When drawing small radius rounded backgrounds (e.g. to draw a circle or button) we see visible pixelation (see GH-41226) This is particularly noticable on low DPI devices.
Changelog:
[ANDROID] [FIXED] - Don't use mGapBetweenPaths if not drawing a border
Test Plan:
Built an android app that directly uses CSSBackgroundDrawable to draw a background and verified repro of this issue.
Then modified the code according to this PR and verified that anti-aliasing is appropriately applied