rebuild autolinking cache if empty or invalid #46241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61911114 |
|
This pull request was exported from Phabricator. Differential Revision: D61911114 |
blakef
force-pushed
the
export-D61911114
branch
from
688b344 to
cb10a20
Compare
blakef
added a commit
to blakef/react-native
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#46241 Our test for rebuilding the `autolinking.json` file currently rebuilds everytime if the cached json file ISN'T empty. This means users who have an empty entry get stuck there. I've also added more validation that the contents of the cached config have at a minimum the `.project.android.packageName` entry in it, otherwise it rebuilds. Changelog: [Internal] Closes 46134 Reviewed By: cortinico Differential Revision: D61911114
|
This pull request was exported from Phabricator. Differential Revision: D61911114 |
blakef
added a commit
to blakef/react-native
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#46241 Our test for rebuilding the `autolinking.json` file currently rebuilds everytime if the cached json file ISN'T empty. This means users who have an empty entry get stuck there. I've also added more validation that the contents of the cached config have at a minimum the `.project.android.packageName` entry in it, otherwise it rebuilds. Closes 46134 Reviewed By: cortinico Differential Revision: D61911114
blakef
force-pushed
the
export-D61911114
branch
from
cb10a20 to
97048a9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61911114 |
blakef
added a commit
to blakef/react-native
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#46241 Our test for rebuilding the `autolinking.json` file currently rebuilds everytime if the cached json file ISN'T empty. This means users who have an empty entry get stuck there. I've also added more validation that the contents of the cached config have at a minimum the `.project.android.packageName` entry in it, otherwise it rebuilds. Changelog: [Internal] Closes 46134 Reviewed By: cortinico Differential Revision: D61911114
blakef
force-pushed
the
export-D61911114
branch
from
97048a9 to
408adfa
Compare
Summary: Pull Request resolved: facebook#46241 Our test for rebuilding the `autolinking.json` file currently rebuilds everytime if the cached json file ISN'T empty. This means users who have an empty entry get stuck there. I've also added more validation that the contents of the cached config have at a minimum the `.project.android.packageName` entry in it, otherwise it rebuilds. Changelog: [Internal] Closes 46134 Reviewed By: cortinico Differential Revision: D61911114
|
This pull request was exported from Phabricator. Differential Revision: D61911114 |
blakef
force-pushed
the
export-D61911114
branch
from
408adfa to
ea193e3
Compare
|
This pull request has been merged in 0f66a69. |
|
This pull request was successfully merged by @blakef in 0f66a69 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Sep 11, 2024
Summary: Pull Request resolved: #46241 Our test for rebuilding the `autolinking.json` file currently rebuilds everytime if the cached json file ISN'T empty. This means users who have an empty entry get stuck there. I've also added more validation that the contents of the cached config have at a minimum the `.project.android.packageName` entry in it, otherwise it rebuilds. Changelog: [Internal] Closes 46134 Reviewed By: cortinico Differential Revision: D61911114 fbshipit-source-id: 188c7f975ce05802c8ea06eaa48345c2bc96f2b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Our test for rebuilding the
autolinking.jsonfile currently rebuilds everytime if the cached json file ISN'T empty. This means users who have an empty entry get stuck there.I've also added more validation that the contents of the cached config have at a minimum the
.project.android.packageNameentry in it, otherwise it rebuilds.Reviewed By: cortinico
Differential Revision: D61911114