Support simple opacity in nested text #46267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61999163 |
|
This pull request was exported from Phabricator. Differential Revision: D61999163 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: facebook#46267 We can propagate opacity, already part of AttributedString, to alpha channel of paint used to draw text and background on canvas. This does not support propagating to views, and contrary to the iOS example added for legacy arch I added, does not correctly support nesting opacity. This is a limitation of new arch more generally, where the information of overlapped opacity is discarded before the AttributedString is set. Bg and foreground are drawn separately with alpha as well, instead of rendering overlapping content offscreen to properly apply it (this is an issue on RN Android more generally, and existing color alpha support, but is pretty noticeable here). This impl targets new arch only. Changelog: [Android][Added] - Support simple opacity in nested text Differential Revision: D61999163
NickGerleman
force-pushed
the
export-D61999163
branch
from
7a53592 to
654a06a
Compare
Summary: Pull Request resolved: facebook#46267 We can propagate opacity, already part of AttributedString, to alpha channel of paint used to draw text and background on canvas. This does not support propagating to views, and contrary to the iOS example added which originated with legacy arch, does not correctly support nesting opacity. This is a limitation of new arch more generally, where an AttributedString fragment only contains inner-most opacity. Bg and foreground are drawn separately with alpha as well, instead of rendering overlapping content offscreen to properly apply it (this is an issue on RN Android more generally, and existing color alpha support, but is pretty noticeable here). This impl targets new arch only. Changelog: [Android][Added] - Support simple opacity in nested text Reviewed By: alanleedev Differential Revision: D61999163
|
This pull request was exported from Phabricator. Differential Revision: D61999163 |
NickGerleman
force-pushed
the
export-D61999163
branch
from
654a06a to
40a72c3
Compare
|
This pull request has been merged in a2d53d5. |
|
This pull request was successfully merged by @NickGerleman in a2d53d5 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We can propagate opacity, already part of AttributedString, to alpha channel of paint used to draw text and background on canvas.
This does not support propagating to views, and contrary to the iOS example added for legacy arch I added, does not correctly support nesting opacity. This is a limitation of new arch more generally, where the information of overlapped opacity is discarded before the AttributedString is set.
This impl targets new arch only.
Changelog:
[Android][Added] - Support simple opacity in nested text
Differential Revision: D61999163