Update InspectorFlags to use NDEBUG flag #46282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61966685 |
Summary: Pull Request resolved: facebook#46282 We intended to enable Fusebox on `main` since facebook#45469 — this worked when building under Buck, however was not working for builds under Xcode/Android Studio. This is because the `HERMES_ENABLE_DEBUGGER` preprocessor flag is not equivalently defined in these build configurations. This diff genericises these checks to `!defined(NDEBUG)` (i.e. *any debug build*), meaning we are correctly able to evaluate the `ReactNativeFeatureFlags::fuseboxEnabledDebug()` setting. Changelog: [Internal] NOTE: `NDEBUG` should be the as-generic-as-possible choice to select a debug build in both OSS and fbsource. Having `HERMES_ENABLE_DEBUGGER` set remains significant (AFAIK) **within the Hermes codebase** (there are no other references in `jsinspector-modern`). Evaluation of whether the lack of this flag works in OSS continues in T200241280. Reviewed By: hoxyq Differential Revision: D61966685
|
This pull request was exported from Phabricator. Differential Revision: D61966685 |
huntie
force-pushed
the
export-D61966685
branch
from
c47bec9 to
cb884df
Compare
|
This pull request has been merged in f00e8ba. |
|
This pull request was successfully merged by @huntie in f00e8ba When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been reverted by 305b435. |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 9, 2024
Summary: > [!Note] > Replaces facebook#46282. We intended to enable Fusebox on `main` since facebook#45469 — this worked when building under Buck, however was not working for builds under Xcode. This is because the `HERMES_ENABLE_DEBUGGER` preprocessor flag was missing for the `React-jsinspector` Podspec. Differential Revision: D62375148
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
…ods (#46393) Summary: Pull Request resolved: #46393 > [!Note] > Replaces #46282. We intended to enable Fusebox on `main` since #45469 — this worked when building under Buck, however was not working for builds under Xcode. This is because the `HERMES_ENABLE_DEBUGGER` preprocessor flag was missing for the `React-jsinspector` Podspec. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D62375148 fbshipit-source-id: 5d4d243d0a2cb7796fdf59d57086a0cb966639c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We intended to enable Fusebox on
mainsince #45469 — this worked when building under Buck, however was not working for builds under Xcode/Android Studio. This is because theHERMES_ENABLE_DEBUGGERpreprocessor flag is not equivalently defined in these build configurations.This diff genericises these checks to
!defined(NDEBUG)(i.e. any debug build), meaning we are correctly able to evaluate theReactNativeFeatureFlags::fuseboxEnabledDebug()setting.Changelog: [Internal]
NOTE:
NDEBUGshould be the as-generic-as-possible choice to select a debug build in both OSS and fbsource. HavingHERMES_ENABLE_DEBUGGERset remains significant (AFAIK) within the Hermes codebase (there are no other references injsinspector-modern). Evaluation of whether the lack of this flag works in OSS continues in T200241280.Reviewed By: hoxyq
Differential Revision: D61966685