Animated: Remove Validation from Production Builds #46287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62055674 |
|
This pull request was exported from Phabricator. Differential Revision: D62055674 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebook#46287 Refactors `Animated` so that the memory and runtime overhead of validating certain values is no longer present in production builds. This will reduce app size and improve the performance of apps using `Animated`. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors, and omitted this logic from production bundles to improve performance Differential Revision: D62055674
yungsters
force-pushed
the
export-D62055674
branch
from
e379f7a to
7d298bb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62055674 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebook#46287 Refactors `Animated` so that the memory and runtime overhead of validating certain values is no longer present in production builds. This will reduce app size and improve the performance of apps using `Animated`. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors, and omitted this logic from production bundles to improve performance Differential Revision: D62055674
yungsters
force-pushed
the
export-D62055674
branch
from
7d298bb to
7031d3e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62055674 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebook#46287 Refactors `Animated` so that the memory and runtime overhead of validating certain values is no longer present in production builds. This will reduce app size and improve the performance of apps using `Animated`. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors, and omitted this logic from production bundles to improve performance Reviewed By: sammy-SC Differential Revision: D62055674
yungsters
force-pushed
the
export-D62055674
branch
from
7031d3e to
f77dfe4
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebook#46287 Refactors `Animated` so that the memory and runtime overhead of validating certain values is no longer present in production builds. This will reduce app size and improve the performance of apps using `Animated`. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors, and omitted this logic from production bundles to improve performance Reviewed By: sammy-SC Differential Revision: D62055674
yungsters
force-pushed
the
export-D62055674
branch
from
f77dfe4 to
eade683
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62055674 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebook#46287 Changes `Animated` to avoid validating certain values in production builds to improve performance. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors Reviewed By: sammy-SC Differential Revision: D62055674
|
This pull request was exported from Phabricator. Differential Revision: D62055674 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebook#46287 Changes `Animated` to avoid validating certain values in production builds to improve performance. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors Reviewed By: sammy-SC Differential Revision: D62055674
yungsters
force-pushed
the
export-D62055674
branch
from
eade683 to
ac085c8
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebook#46287 Refactors `Animated` so that the memory and runtime overhead of validating certain values is no longer present in production builds. This will reduce app size and improve the performance of apps using `Animated`. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors, and omitted this logic from production bundles to improve performance Differential Revision: D62055674 Reviewed By: sammy-SC
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebook#46287 Changes `Animated` to avoid validating certain values in production builds to improve performance. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors Reviewed By: sammy-SC Differential Revision: D62055674
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebook#46287 Changes `Animated` to avoid validating certain values in production builds to improve performance. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors Reviewed By: sammy-SC Differential Revision: D62055674
|
This pull request was exported from Phabricator. Differential Revision: D62055674 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebook#46287 Changes `Animated` to avoid validating certain values in production builds to improve performance. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors Reviewed By: sammy-SC Differential Revision: D62055674
yungsters
force-pushed
the
export-D62055674
branch
from
ac085c8 to
d3d3e9f
Compare
Summary: Pull Request resolved: facebook#46287 Changes `Animated` to avoid validating certain values in production builds to improve performance. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors Reviewed By: sammy-SC Differential Revision: D62055674
|
This pull request was exported from Phabricator. Differential Revision: D62055674 |
yungsters
force-pushed
the
export-D62055674
branch
from
d3d3e9f to
08deeb8
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebook#46287 Changes `Animated` to avoid validating certain values in production builds to improve performance. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors Reviewed By: sammy-SC Differential Revision: D62055674
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebook#46287 Changes `Animated` to avoid validating certain values in production builds to improve performance. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors Reviewed By: sammy-SC Differential Revision: D62055674
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: facebook#46287 Changes `Animated` to avoid validating certain values in production builds to improve performance. In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use `console.error` instead of error throwing. Changelog: [General][Changed] - Changed `Animated` props validation to soft errors instead of thrown errors Reviewed By: sammy-SC Differential Revision: D62055674
|
This pull request has been merged in 0a1ba02. |
|
This pull request was successfully merged by @yungsters in 0a1ba02 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactors
Animatedso that the memory and runtime overhead of validating certain values is no longer present in production builds.This will reduce app size and improve the performance of apps using
Animated.In order to maintain consistent behavior between development and production builds (so that we reduce the likelihood of bugs that only appear in one of the environments), this also changes the validation errors to use
console.errorinstead of error throwing.Changelog:
[General][Changed] - Changed
Animatedprops validation to soft errors instead of thrown errors, and omitted this logic from production bundles to improve performanceDifferential Revision: D62055674