fix broken test due to error message change #46329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62184078 |
Summary: ## Context The error message in folly dynamic has been updated in D62136190. Updating related tests to reflect the change. ## Diff Only test code is changed. No business logic change. ## Changelog: [Internal] [Fixed] - Fix broken unit test due to folly error message change Pull Request resolved: facebook#46329 ``` Shows details about the selected run from the run history Run result java.lang.AssertionError: Test failure Test Case RecoverableError * Running RecoverableError.RunRethrowingAsRecoverableRecoverTest * Running RecoverableError.RunRethrowingAsRecoverableFallthroughTest 2/2 tests passed. Test Case JsArgumentHelpersTest * Running JsArgumentHelpersTest.args ***** Failure in xplat/js/react-native-github/packages/react-native/ReactCommon/cxxreact/tests/jsarg_helpers.cpp:108 Expected equality of these values: ex.what() Which is: "Error converting javascript arg 4 to C++: TypeError: expected dynamic type 'int/double/bool/string', but had type 'array'" std::string("Error converting javascript arg 4 to C++: " "TypeError: expected dynamic type `int/double/bool/string', but had type `array'") Which is: "Error converting javascript arg 4 to C++: TypeError: expected dynamic type `int/double/bool/string', but had type `array'" 0/1 tests passed. Test Case JSBigFileString ``` Reviewed By: yfeldblum Differential Revision: D62184078
|
This pull request was exported from Phabricator. Differential Revision: D62184078 |
Zhao-Qi
force-pushed
the
export-D62184078
branch
from
f4fcff1 to
c93d3be
Compare
|
This pull request has been merged in e864663. |
|
This pull request was successfully merged by Qi Zhao in e864663 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Sep 4, 2024
Summary: ## Context The error message in folly dynamic has been updated in D62136190. Updating related tests to reflect the change. ## Diff Only test code is changed. No business logic change. ## Changelog: [Internal] [Fixed] - Fix broken unit test due to folly error message change X-link: facebook/react-native#46329 ``` Shows details about the selected run from the run history Run result java.lang.AssertionError: Test failure Test Case RecoverableError * Running RecoverableError.RunRethrowingAsRecoverableRecoverTest * Running RecoverableError.RunRethrowingAsRecoverableFallthroughTest 2/2 tests passed. Test Case JsArgumentHelpersTest * Running JsArgumentHelpersTest.args ***** Failure in xplat/js/react-native-github/packages/react-native/ReactCommon/cxxreact/tests/jsarg_helpers.cpp:108 Expected equality of these values: ex.what() Which is: "Error converting javascript arg 4 to C++: TypeError: expected dynamic type 'int/double/bool/string', but had type 'array'" std::string("Error converting javascript arg 4 to C++: " "TypeError: expected dynamic type `int/double/bool/string', but had type `array'") Which is: "Error converting javascript arg 4 to C++: TypeError: expected dynamic type `int/double/bool/string', but had type `array'" 0/1 tests passed. Test Case JSBigFileString ``` Reviewed By: yfeldblum Differential Revision: D62184078 fbshipit-source-id: 6ae0a33f58e0e10f14166084b80a997e59a008ec
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Sep 11, 2024
Summary: ## Context The error message in folly dynamic has been updated in D62136190. Updating related tests to reflect the change. ## Diff Only test code is changed. No business logic change. ## Changelog: [Internal] [Fixed] - Fix broken unit test due to folly error message change X-link: facebook/react-native#46329 ``` Shows details about the selected run from the run history Run result java.lang.AssertionError: Test failure Test Case RecoverableError * Running RecoverableError.RunRethrowingAsRecoverableRecoverTest * Running RecoverableError.RunRethrowingAsRecoverableFallthroughTest 2/2 tests passed. Test Case JsArgumentHelpersTest * Running JsArgumentHelpersTest.args ***** Failure in xplat/js/react-native-github/packages/react-native/ReactCommon/cxxreact/tests/jsarg_helpers.cpp:108 Expected equality of these values: ex.what() Which is: "Error converting javascript arg 4 to C++: TypeError: expected dynamic type 'int/double/bool/string', but had type 'array'" std::string("Error converting javascript arg 4 to C++: " "TypeError: expected dynamic type `int/double/bool/string', but had type `array'") Which is: "Error converting javascript arg 4 to C++: TypeError: expected dynamic type `int/double/bool/string', but had type `array'" 0/1 tests passed. Test Case JSBigFileString ``` Reviewed By: yfeldblum Differential Revision: D62184078 fbshipit-source-id: 6ae0a33f58e0e10f14166084b80a997e59a008ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D62184078