Add offset to InspectorPanel #46340
Closed
Add offset to InspectorPanel #46340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62225374 |
Summary: Pull Request resolved: facebook#46341 Issue: LogBox Notification (or toast) is partly hidden behind 3 button nav bar on Android 15 targetSdk 35 build Solution: surround with SafeAreaView to avoid overlap with system bars (CAUTION: SafeAreaView here is for internal RN Core usage only and should not be used elsewhere) Changelog: [Internal] Differential Revision: D62224584 Reviewed By: cortinico, mdvacca
Summary: Pull Request resolved: facebook#46340 **Issue:** InspectorPanel is hidden behind 3 button nav bar on Android 15 forced edge-to-edge **Solution:** Apply SafeAreaView to avoid overlap with system bars (CAUTION: SafeAreaView here is for internal RN Core usage only and should not be used elsewhere) Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D62225374
|
This pull request was exported from Phabricator. Differential Revision: D62225374 |
alanleedev
force-pushed
the
export-D62225374
branch
from
91a9631 to
ac13e99
Compare
|
This pull request has been merged in 3bd3d76. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue:
InspectorPanel is hidden behind 3 button nav bar on Android 15 forced edge-to-edge
Solution:
Selectively add additional offset for Android 15.
This does have drawback as forced edge-to-edge is enabled with targetSdk 35 build so even if you are on Android 15, targetSdk 34 builds will not be forced edge-to-edge so it adds extra offset.
Changelog:
[Android][Changed] - adjust InspectorPanel offset so it won't overlap with system bars on forced edge-to-edge on Android 15
Differential Revision: D62225374