Animated: Minimize AnimatedProps Invalidation
#46386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61997128 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D61997128 |
yungsters
force-pushed
the
export-D61997128
branch
from
acc7ba3
to
caee808
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 8, 2024
Summary: Pull Request resolved: facebook#46386 Currently, `useAnimatedProps` attempts (and fails) to memoize the `AnimatedProps` instance by using `props` in the dependency array: https://www.internalfb.com/code/fbsource/[de6bf108ae11fad0e8516617cde6f0cf3152d129]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=56-59 However, `props` is very easily invalidated whenever the component is updated by its parent. The only time when it will not be invalidated is if the component that directly uses this hook — `createAnimatedComponent`'s return value — updates state… which never happens. This changes `useAnimatedProps` so that we memoize `AnimatedProps` using only the nested property values that actually require a new `AnimatedProps` object to be created, which are `AnimatedNode` subclasses. A minor detail is that in order for `AnimatedProps.prototype.__getValue` to continue working, we must supply `props` when we're actualizing the `AnimatedNode` instances into real values. This is accomplished by introducing a new method to select `AnimatedNode` subclasses: `__getValueFromStatic{Props,Object,Style,Transforms}` [General][Added] - Created an experimental optimization to improve memoization within `Animated` to improve product performance Differential Revision: D61997128
|
This pull request was exported from Phabricator. Differential Revision: D61997128 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 8, 2024
Summary: Pull Request resolved: facebook#46386 Currently, `useAnimatedProps` attempts (and fails) to memoize the `AnimatedProps` instance by using `props` in the dependency array: https://www.internalfb.com/code/fbsource/[de6bf108ae11fad0e8516617cde6f0cf3152d129]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=56-59 However, `props` is very easily invalidated whenever the component is updated by its parent. The only time when it will not be invalidated is if the component that directly uses this hook — `createAnimatedComponent`'s return value — updates state… which never happens. This changes `useAnimatedProps` so that we memoize `AnimatedProps` using only the nested property values that actually require a new `AnimatedProps` object to be created, which are `AnimatedNode` subclasses. A minor detail is that in order for `AnimatedProps.prototype.__getValue` to continue working, we must supply `props` when we're actualizing the `AnimatedNode` instances into real values. This is accomplished by introducing a new method to select `AnimatedNode` subclasses: `__getValueFromStatic{Props,Object,Style,Transforms}` [General][Added] - Created an experimental optimization to improve memoization within `Animated` to improve product performance Differential Revision: D61997128
yungsters
force-pushed
the
export-D61997128
branch
from
caee808
to
ddc3a02
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61997128 |
yungsters
force-pushed
the
export-D61997128
branch
from
ddc3a02
to
9a86c03
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 9, 2024
Summary: Pull Request resolved: facebook#46386 Currently, `useAnimatedProps` attempts (and fails) to memoize the `AnimatedProps` instance by using `props` in the dependency array: https://www.internalfb.com/code/fbsource/[de6bf108ae11fad0e8516617cde6f0cf3152d129]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=56-59 However, `props` is very easily invalidated whenever the component is updated by its parent. The only time when it will not be invalidated is if the component that directly uses this hook — `createAnimatedComponent`'s return value — updates state… which never happens. This changes `useAnimatedProps` so that we memoize `AnimatedProps` using only the nested property values that actually require a new `AnimatedProps` object to be created, which are `AnimatedNode` subclasses. A minor detail is that in order for `AnimatedProps.prototype.__getValue` to continue working, we must supply `props` when we're actualizing the `AnimatedNode` instances into real values. This is accomplished by introducing a new method to select `AnimatedNode` subclasses: `__getValueFromStatic{Props,Object,Style,Transforms}` [General][Added] - Created an experimental optimization to improve memoization within `Animated` to improve product performance Differential Revision: D61997128
|
This pull request was exported from Phabricator. Differential Revision: D61997128 |
yungsters
force-pushed
the
export-D61997128
branch
from
9a86c03
to
60e8fb3
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: facebook#46386 Currently, `useAnimatedProps` attempts (and fails) to memoize the `AnimatedProps` instance by using `props` in the dependency array: https://www.internalfb.com/code/fbsource/[de6bf108ae11fad0e8516617cde6f0cf3152d129]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=56-59 However, `props` is very easily invalidated whenever the component is updated by its parent. The only time when it will not be invalidated is if the component that directly uses this hook — `createAnimatedComponent`'s return value — updates state… which never happens. This changes `useAnimatedProps` so that we memoize `AnimatedProps` using only the nested property values that actually require a new `AnimatedProps` object to be created, which are `AnimatedNode` subclasses. A minor detail is that in order for `AnimatedProps.prototype.__getValue` to continue working, we must supply `props` when we're actualizing the `AnimatedNode` instances into real values. This is accomplished by introducing a new method to select `AnimatedNode` subclasses: `__getValueFromStatic{Props,Object,Style,Transforms}` [General][Added] - Created an experimental optimization to improve memoization within `Animated` to improve product performance Differential Revision: D61997128
|
This pull request was exported from Phabricator. Differential Revision: D61997128 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: facebook#46386 Currently, `useAnimatedProps` attempts (and fails) to memoize the `AnimatedProps` instance by using `props` in the dependency array: https://www.internalfb.com/code/fbsource/[de6bf108ae11fad0e8516617cde6f0cf3152d129]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=56-59 However, `props` is very easily invalidated whenever the component is updated by its parent. The only time when it will not be invalidated is if the component that directly uses this hook — `createAnimatedComponent`'s return value — updates state… which never happens. This changes `useAnimatedProps` so that we memoize `AnimatedProps` using only the nested property values that actually require a new `AnimatedProps` object to be created, which are `AnimatedNode` subclasses. A minor detail is that in order for `AnimatedProps.prototype.__getValue` to continue working, we must supply `props` when we're actualizing the `AnimatedNode` instances into real values. This is accomplished by introducing a new method to select `AnimatedNode` subclasses: `__getValueFromStatic{Props,Object,Style,Transforms}` [General][Added] - Created an experimental optimization to improve memoization within `Animated` to improve product performance Differential Revision: D61997128
yungsters
force-pushed
the
export-D61997128
branch
from
60e8fb3
to
b5b2d5d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61997128 |
yungsters
force-pushed
the
export-D61997128
branch
from
b5b2d5d
to
6662345
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: facebook#46386 Currently, `useAnimatedProps` attempts (and fails) to memoize the `AnimatedProps` instance by using `props` in the dependency array: https://www.internalfb.com/code/fbsource/[de6bf108ae11fad0e8516617cde6f0cf3152d129]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=56-59 However, `props` is very easily invalidated whenever the component is updated by its parent. The only time when it will not be invalidated is if the component that directly uses this hook — `createAnimatedComponent`'s return value — updates state… which never happens. This changes `useAnimatedProps` so that we memoize `AnimatedProps` using only the nested property values that actually require a new `AnimatedProps` object to be created, which are `AnimatedNode` subclasses. A minor detail is that in order for `AnimatedProps.prototype.__getValue` to continue working, we must supply `props` when we're actualizing the `AnimatedNode` instances into real values. This is accomplished by introducing a new method to select `AnimatedNode` subclasses: `__getValueFromStatic{Props,Object,Style,Transforms}` [General][Added] - Created an experimental optimization to improve memoization within `Animated` to improve product performance Differential Revision: D61997128
|
This pull request was exported from Phabricator. Differential Revision: D61997128 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: facebook#46386 Currently, `useAnimatedProps` attempts (and fails) to memoize the `AnimatedProps` instance by using `props` in the dependency array: https://www.internalfb.com/code/fbsource/[de6bf108ae11fad0e8516617cde6f0cf3152d129]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=56-59 However, `props` is very easily invalidated whenever the component is updated by its parent. The only time when it will not be invalidated is if the component that directly uses this hook — `createAnimatedComponent`'s return value — updates state… which never happens. This changes `useAnimatedProps` so that we memoize `AnimatedProps` using only the nested property values that actually require a new `AnimatedProps` object to be created, which are `AnimatedNode` subclasses. A minor detail is that in order for `AnimatedProps.prototype.__getValue` to continue working, we must supply `props` when we're actualizing the `AnimatedNode` instances into real values. This is accomplished by introducing a new method to select `AnimatedNode` subclasses: `__getValueFromStatic{Props,Object,Style,Transforms}` [General][Added] - Created an experimental optimization to improve memoization within `Animated` to improve product performance Differential Revision: D61997128
yungsters
force-pushed
the
export-D61997128
branch
from
6662345
to
63b8db7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61997128 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: facebook#46386 Currently, `useAnimatedProps` attempts (and fails) to memoize the `AnimatedProps` instance by using `props` in the dependency array: https://www.internalfb.com/code/fbsource/[de6bf108ae11fad0e8516617cde6f0cf3152d129]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=56-59 However, `props` is very easily invalidated whenever the component is updated by its parent. The only time when it will not be invalidated is if the component that directly uses this hook — `createAnimatedComponent`'s return value — updates state… which never happens. This changes `useAnimatedProps` so that we memoize `AnimatedProps` using only the nested property values that actually require a new `AnimatedProps` object to be created, which are `AnimatedNode` subclasses. A minor detail is that in order for `AnimatedProps.prototype.__getValue` to continue working, we must supply `props` when we're actualizing the `AnimatedNode` instances into real values. This is accomplished by introducing a new method to select `AnimatedNode` subclasses: `__getValueFromStatic{Props,Object,Style,Transforms}` [General][Added] - Created an experimental optimization to improve memoization within `Animated` to improve product performance Differential Revision: D61997128
yungsters
force-pushed
the
export-D61997128
branch
from
63b8db7
to
fa4c73b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61997128 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: facebook#46386 Currently, `useAnimatedProps` attempts (and fails) to memoize the `AnimatedProps` instance by using `props` in the dependency array: https://www.internalfb.com/code/fbsource/[de6bf108ae11fad0e8516617cde6f0cf3152d129]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=56-59 However, `props` is very easily invalidated whenever the component is updated by its parent. The only time when it will not be invalidated is if the component that directly uses this hook — `createAnimatedComponent`'s return value — updates state… which never happens. This changes `useAnimatedProps` so that we memoize `AnimatedProps` using only the nested property values that actually require a new `AnimatedProps` object to be created, which are `AnimatedNode` subclasses. A minor detail is that in order for `AnimatedProps.prototype.__getValue` to continue working, we must supply `props` when we're actualizing the `AnimatedNode` instances into real values. This is accomplished by introducing a new method to select `AnimatedNode` subclasses: `__getValueFromStatic{Props,Object,Style,Transforms}` [General][Added] - Created an experimental optimization to improve memoization within `Animated` to improve product performance Differential Revision: D61997128
yungsters
force-pushed
the
export-D61997128
branch
from
fa4c73b
to
df1784f
Compare
Summary: Pull Request resolved: facebook#46386 Currently, `useAnimatedProps` attempts (and fails) to memoize the `AnimatedProps` instance by using `props` in the dependency array: https://www.internalfb.com/code/fbsource/[de6bf108ae11fad0e8516617cde6f0cf3152d129]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=56-59 However, `props` is very easily invalidated whenever the component is updated by its parent. The only time when it will not be invalidated is if the component that directly uses this hook — `createAnimatedComponent`'s return value — updates state… which never happens. This changes `useAnimatedProps` so that we memoize `AnimatedProps` using only the nested property values that actually require a new `AnimatedProps` object to be created, which are `AnimatedNode` subclasses. A minor detail is that in order for `AnimatedProps.prototype.__getValue` to continue working, we must supply `props` when we're actualizing the `AnimatedNode` instances into real values. This is accomplished by introducing a new method to select `AnimatedNode` subclasses: `__getValueFromStatic{Props,Object,Style,Transforms}` Changelog: [General][Added] - Created an experimental optimization to improve memoization within `Animated` to improve product performance Differential Revision: D61997128
yungsters
force-pushed
the
export-D61997128
branch
from
df1784f
to
77d9b87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61997128 |
|
This pull request has been merged in dc84d00. |
|
This pull request was successfully merged by @yungsters in dc84d00 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently,
useAnimatedPropsattempts (and fails) to memoize theAnimatedPropsinstance by usingpropsin the dependency array:https://www.internalfb.com/code/fbsource/[de6bf108ae11fad0e8516617cde6f0cf3152d129]/xplat/js/react-native-github/packages/react-native/Libraries/Animated/useAnimatedProps.js?lines=56-59
However,
propsis very easily invalidated whenever the component is updated by its parent. The only time when it will not be invalidated is if the component that directly uses this hook —createAnimatedComponent's return value — updates state… which never happens.This changes
useAnimatedPropsso that we memoizeAnimatedPropsusing only the nested property values that actually require a newAnimatedPropsobject to be created, which areAnimatedNodesubclasses.A minor detail is that in order for
AnimatedProps.prototype.__getValueto continue working, we must supplypropswhen we're actualizing theAnimatedNodeinstances into real values. This is accomplished by introducing a new method to selectAnimatedNodesubclasses:__getValueFromStatic{Props,Object,Style,Transforms}[General][Added] - Created an experimental optimization to improve memoization within
Animatedto improve product performanceDifferential Revision: D61997128