fix SafeAreaView mis-used import #46402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: JS code for importing SafeAreaView is causing error in windows due to import being used. Fix it by using conditional require instead Changelog: [Internal] - Fixed mis-used import of core only SafeAreaView in JS Differential Revision: D62392588
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62392588 |
|
This pull request has been merged in af1b18e. |
|
This pull request was successfully merged by @alanleedev in af1b18e When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Sep 16, 2024
Summary: Pull Request resolved: #46402 JS code for importing SafeAreaView is causing error in windows due to import being used. Fix it by using conditional require instead Changelog: [Internal] - Fixed mis-used import of core only SafeAreaView in JS Reviewed By: fkgozali Differential Revision: D62392588 fbshipit-source-id: 65c4728ff73b43cc54543ec2d141a88fce1275ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
JS code for importing SafeAreaView is causing error in windows due to import being used.
Fix it by using conditional require instead
Changelog:
[Internal] - Fixed mis-used import of core only SafeAreaView in JS
Differential Revision: D62392588