Expose hermestooling via prefab #46423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is used by Reanimated as they were previously accessing `libhermes_executor.so` Changelog: [Android] [Changed] - Expose hermestooling via prefab Reviewed By: cipolleschi Differential Revision: D62447875
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62447875 |
|
This pull request has been merged in f41af55. |
|
This pull request was successfully merged by @cortinico in f41af55 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
Summary: This PR exposes `jsctooling` prefab that contains `facebook::jsc::makeJSCRuntime` used by Reanimated and other third-party libraries previously accessed via `libjscexecutor.so`. Based on #46423. ## Changelog: [Android] [Changed] - Expose jsctooling via prefab Pull Request resolved: #46430 Test Plan: Tested on Reanimated paper-example app built from source on RN 0.76.0-rc.0 with JSC enabled Reviewed By: cipolleschi Differential Revision: D62492763 Pulled By: cortinico fbshipit-source-id: 53b6c0d9bb88559c40b5b8796bf6a1513bd388d9
cipolleschi
pushed a commit
that referenced
this pull request
Sep 16, 2024
Summary: Pull Request resolved: #46423 This is used by Reanimated as they were previously accessing `libhermes_executor.so` Changelog: [Android] [Changed] - Expose hermestooling via prefab Reviewed By: cipolleschi Differential Revision: D62447875 fbshipit-source-id: e863c56bc5a801ee7de8a4e5d45f95481d3497f8
cipolleschi
pushed a commit
that referenced
this pull request
Sep 16, 2024
Summary: This PR exposes `jsctooling` prefab that contains `facebook::jsc::makeJSCRuntime` used by Reanimated and other third-party libraries previously accessed via `libjscexecutor.so`. Based on #46423. ## Changelog: [Android] [Changed] - Expose jsctooling via prefab Pull Request resolved: #46430 Test Plan: Tested on Reanimated paper-example app built from source on RN 0.76.0-rc.0 with JSC enabled Reviewed By: cipolleschi Differential Revision: D62492763 Pulled By: cortinico fbshipit-source-id: 53b6c0d9bb88559c40b5b8796bf6a1513bd388d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is used by Reanimated as they were previously accessing
libhermes_executor.soChangelog:
[Android] [Changed] - Expose hermestooling via prefab
Reviewed By: cipolleschi
Differential Revision: D62447875