ReactNativeNewArchitectureFeatureFlagsDefaults defaults to newArch #46448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62537633 |
|
This pull request was exported from Phabricator. Differential Revision: D62537633 |
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Sep 12, 2024
…acebook#46448) Summary: Pull Request resolved: facebook#46448 [internal] **Context** - D61621224 changed `ReactNativeNewArchitectureFeatureFlagsDefaults` to default `newArchitectureEnabled=true` https://www.internalfb.com/code/fbsource/[dc23ff7ddd18]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt?lines=16-18 **Change** - We no longer need to explicitly set `newArchitectureEnabled=true` Differential Revision: D62537633
shwanton
force-pushed
the
export-D62537633
branch
from
091f707 to
d3d0780
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62537633 |
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Sep 12, 2024
…acebook#46448) Summary: Pull Request resolved: facebook#46448 [internal] **Context** - D61621224 changed `ReactNativeNewArchitectureFeatureFlagsDefaults` to default `newArchitectureEnabled=true` https://www.internalfb.com/code/fbsource/[dc23ff7ddd18]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt?lines=16-18 **Change** - We no longer need to explicitly set `newArchitectureEnabled=true` Differential Revision: D62537633
shwanton
force-pushed
the
export-D62537633
branch
from
d3d0780 to
ab5ec5b
Compare
…acebook#46448) Summary: Pull Request resolved: facebook#46448 Changelog: [Internal] **Context** - D61621224 changed `ReactNativeNewArchitectureFeatureFlagsDefaults` to default `newArchitectureEnabled=true` https://www.internalfb.com/code/fbsource/[dc23ff7ddd18]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt?lines=16-18 **Change** - We no longer need to explicitly set `newArchitectureEnabled=true` Reviewed By: cortinico Differential Revision: D62537633
|
This pull request was exported from Phabricator. Differential Revision: D62537633 |
shwanton
force-pushed
the
export-D62537633
branch
from
ab5ec5b to
08d3bbb
Compare
|
This pull request has been merged in ec39b8b. |
|
This pull request was successfully merged by @shwanton in ec39b8b When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Context
ReactNativeNewArchitectureFeatureFlagsDefaultsto defaultnewArchitectureEnabled=truehttps://www.internalfb.com/code/fbsource/[dc23ff7ddd18]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt?lines=16-18
Change
newArchitectureEnabled=trueDifferential Revision: D62537633