Commits on Oct 28, 2024

1. Add featureflag to not re-order mount items in FabricMountingManager (f… …

   …acebook#46702)
   
   Summary:
   Pull Request resolved: facebook#46702
   
   In facebook#44188, we've started combining multiple transactions in a single transaction, to meet React's atomicity requirements, while also dealing with the constraints of Android's Fabric implementation.
   
   This revealed a bug where in some scenarios (especially when using transitions), a node may be deleted and created during the same transaction. The current implementation of FabricMountingManager assumes it can safely reorder some operations, which it does to optimize the size of IntBufferBatch mount items. This is however incorrect and unsafe when multiple transactions are merged.
   
   **Example:**
   
   Differentiator output:
   
   ```
   # Transaction 1
   Remove facebook#100 from facebook#11
   Delete facebook#100
   
   # Transaction 2
   Create facebook#100
   Insert facebook#100 into facebook#11
   ```
   FabricMountingManager output
   ```
   Remove facebook#100 from facebook#11
   Insert facebook#100 into facebook#11
   Delete facebook#100
   ```
   
   Note that the create action is also skipped, because we only update `allocatedViewTags` after processing all mutations, leading FabricMountingManager to assume creation is not required.
   
   This leads to an invalid state in SurfaceMountingManager, which will be surfaced as a crash in `getViewState` on the next mutation that interacts with these views.
   
   Changelog: [Android][Fixed] Fix crash in getViewState when using suspense fallbacks.
   
   Reviewed By: sammy-SC
   
   Differential Revision: D63148523

   

   javache authored and facebook-github-bot committed Oct 28, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for bc986d0
   • Browse repository at this point

   Copy the full SHA

   bc986d0 View commit details

   Browse the repository at this point in the history