Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Windows): Fix cast and control paths errors on windows #46899

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ uint32_t PerformanceEntryReporter::getDroppedEntriesCount(
PerformanceEntryType entryType) const noexcept {
std::shared_lock lock(buffersMutex_);

return getBuffer(entryType).droppedEntriesCount;
return (uint32_t)getBuffer(entryType).droppedEntriesCount;
}

std::vector<PerformanceEntry> PerformanceEntryReporter::getEntries() const {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ class PerformanceEntryReporter {
case PerformanceEntryType::_NEXT:
throw std::logic_error("Cannot get buffer for _NEXT entry type");
}
throw std::logic_error("Unhandled PerformanceEntryType");
}

inline PerformanceEntryBuffer& getBufferRef(PerformanceEntryType entryType) {
Expand All @@ -140,6 +141,7 @@ class PerformanceEntryReporter {
case PerformanceEntryType::_NEXT:
throw std::logic_error("Cannot get buffer for _NEXT entry type");
}
throw std::logic_error("Unhandled PerformanceEntryType");
}
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ ScrollViewProps::ScrollViewProps(
rawProps,
"endDraggingSensitivityMultiplier",
sourceProps.endDraggingSensitivityMultiplier,
1)),
(Float)1)),
enableSyncOnScroll(
CoreFeatures::enablePropIteratorSetter
? sourceProps.enableSyncOnScroll
Expand Down
Loading