Make PackagerConnectionSettings class open again #47005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cortinico
approved these changes
Oct 14, 2024
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in 4dd47ee. |
|
This pull request was successfully merged by @gabrieldonadel in 4dd47ee When will my fix make it into a release? | How to file a pick request? |
gabrieldonadel
deleted the
@gabrieldonadel/open-packager-connection-settings
branch
3 tasks
blakef
pushed a commit
that referenced
this pull request
Oct 15, 2024
Summary: When migrating `PackagerConnectionSettings` from Java to Kotlin in #45800 the new class ended up being declared as final, causing a breaking change in 0.76. We should add the `open` directive to `PackagerConnectionSettings.kt` to restore the old behavior. That would be crucial for the `expo-dev-client` package, given that Expo needs to be able to extend this class in order to overwrite the `debugServerHost` value. ## Changelog: [ANDROID] [FIXED] - Make PackagerConnectionSettings class open again Pull Request resolved: #47005 Test Plan: Run RNTester on Android Reviewed By: huntie Differential Revision: D64323645 Pulled By: cortinico fbshipit-source-id: 6870a3dee929ba664e4c402f321f84af7704f892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When migrating
PackagerConnectionSettingsfrom Java to Kotlin in #45800 the new class ended up being declared as final, causing a breaking change in 0.76.We should add the
opendirective toPackagerConnectionSettings.ktto restore the old behavior. That would be crucial for theexpo-dev-clientpackage, given that Expo needs to be able to extend this class in order to overwrite thedebugServerHostvalue.Changelog:
[ANDROID] [FIXED] - Make PackagerConnectionSettings class open again
Test Plan:
Run RNTester on Android