Undo breaking change on UIManager eventDispatcher accessor #47088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64533594 |
cortinico
force-pushed
the
export-D64533594
branch
from
992648f to
acd8050
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 17, 2024
…47088) Summary: Pull Request resolved: facebook#47088 Whe migrating this interface to Kotlin we've subtly introduced a breaking change which is causing a lot of breakages in the ecosystem. This is forcing users to do: ``` // Before reactContext.getNativeModule(UIManagerModule::class.java)!!.eventDispatcher // After reactContext.getNativeModule(UIManagerModule::class.java)!!.getEventDispatcher() ``` This reverts this breaking change. Plus the method had a generic parameters which was completely unnecessary so I'm removing it. Changelog: [Android] [Fixed] - Undo breaking change on UIManager eventDispatcher accessor Reviewed By: cipolleschi Differential Revision: D64533594
|
This pull request was exported from Phabricator. Differential Revision: D64533594 |
cortinico
force-pushed
the
export-D64533594
branch
2 times, most recently
from
872a336 to
9429276
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 17, 2024
…47088) Summary: Whe migrating this interface to Kotlin we've subtly introduced a breaking change which is causing a lot of breakages in the ecosystem. This is forcing users to do: ``` // Before reactContext.getNativeModule(UIManagerModule::class.java)!!.eventDispatcher // After reactContext.getNativeModule(UIManagerModule::class.java)!!.getEventDispatcher() ``` This reverts this breaking change. Plus the method had a generic parameters which was completely unnecessary so I'm removing it. Changelog: [Android] [Fixed] - Undo breaking change on UIManager eventDispatcher accessor Reviewed By: cipolleschi Differential Revision: D64533594
|
This pull request was exported from Phabricator. Differential Revision: D64533594 |
cortinico
added a commit
that referenced
this pull request
Oct 17, 2024
Summary: Whe migrating this interface to Kotlin we've subtly introduced a breaking change which is causing a lot of breakages in the ecosystem. This is forcing users to do: ``` // Before reactContext.getNativeModule(UIManagerModule::class.java)!!.eventDispatcher // After reactContext.getNativeModule(UIManagerModule::class.java)!!.getEventDispatcher() ``` This reverts this breaking change. Plus the method had a generic parameters which was completely unnecessary so I'm removing it. Changelog: [Android] [Fixed] - Undo breaking change on UIManager eventDispatcher accessor Reviewed By: cipolleschi Differential Revision: D64533594
cortinico
force-pushed
the
export-D64533594
branch
from
9429276 to
418514e
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 18, 2024
…47088) Summary: Whe migrating this interface to Kotlin we've subtly introduced a breaking change which is causing a lot of breakages in the ecosystem. This is forcing users to do: ``` // Before reactContext.getNativeModule(UIManagerModule::class.java)!!.eventDispatcher // After reactContext.getNativeModule(UIManagerModule::class.java)!!.getEventDispatcher() ``` This reverts this breaking change. Plus the method had a generic parameters which was completely unnecessary so I'm removing it. Changelog: [Android] [Fixed] - Undo breaking change on UIManager eventDispatcher accessor Reviewed By: cipolleschi Differential Revision: D64533594
|
This pull request was exported from Phabricator. Differential Revision: D64533594 |
…47088) Summary: Whe migrating this interface to Kotlin we've subtly introduced a breaking change which is causing a lot of breakages in the ecosystem. This is forcing users to do: ``` // Before reactContext.getNativeModule(UIManagerModule::class.java)!!.eventDispatcher // After reactContext.getNativeModule(UIManagerModule::class.java)!!.getEventDispatcher() ``` This reverts this breaking change. Plus the method had a generic parameters which was completely unnecessary so I'm removing it. Changelog: [Android] [Fixed] - Undo breaking change on UIManager eventDispatcher accessor Reviewed By: cipolleschi Differential Revision: D64533594
cortinico
force-pushed
the
export-D64533594
branch
from
418514e to
88eff30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64533594 |
|
This pull request has been merged in dc1a498. |
|
This pull request was successfully merged by @cortinico in dc1a498 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Whe migrating this interface to Kotlin we've subtly introduced a breaking change which is causing a lot of breakages in the ecosystem.
This is forcing users to do:
This reverts this breaking change.
Plus the method had a generic parameters which was completely unnecessary so I'm removing it.
Changelog:
[Android] [Fixed] - Undo breaking change on UIManager eventDispatcher accessor
Differential Revision: D64533594