Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #18945 inverted sticky headers (footers actually) not working issue #47130

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Fix #18945 inverted sticky headers (footers actually) not working issue #47130

wants to merge 12 commits into from

Conversation

fangpenlin
Copy link

@fangpenlin fangpenlin commented Oct 19, 2024 •
edited
Loading

Summary:

Fix #18945 inverted sticky headers (footers actually) not working issue

Changelog:

[General] [Fixed] - Fix SectionList sticky footer doesn't work as expected when the list has inverted flag set

Test Plan:

Screen.Recording.2024-10-18.at.8.29.04.PM.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 19, 2024
@fangpenlin
Copy link
Author

Added a test sample file. I tested it in an Android emulator and it appears to be working fine. I haven't test other stuff or platform yet. Here's a screencast of the demo:

Screen.Recording.2024-10-18.at.8.29.04.PM.mov

@fangpenlin fangpenlin mentioned this pull request Oct 19, 2024
Open
3 tasks
@fangpenlin
Copy link
Author

Okay, tested with iOS simulator. It appears to be working as expected

Screen.Recording.2024-10-24.at.1.11.30.PM.mov

@fangpenlin fangpenlin force-pushed the bugfix-18945-inverted-sticky-footer branch from d77d594 to d121241 Compare October 27, 2024 04:17
@fangpenlin fangpenlin marked this pull request as ready for review October 28, 2024 15:08
@fangpenlin fangpenlin changed the title WIP: Fix #18945 inverted sticky headers (footers actually) not working issue Fix #18945 inverted sticky headers (footers actually) not working issue Oct 28, 2024
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 28, 2024
@fangpenlin
Copy link
Author

looks like there are some tests failed, will fix them shortly

@fangpenlin fangpenlin force-pushed the bugfix-18945-inverted-sticky-footer branch from d121241 to d5249a5 Compare October 31, 2024 04:58
@fangpenlin
Copy link
Author

Hey @migueldaipre, @cortinico and @cipolleschi, I've fixed the failing tests. Can you please help me kick start the CI job again as it appears requiring to be kicked started by repo maintainers.

@fangpenlin
Copy link
Author

hmm, okay, looks like some other tests are still failling 😅
will find a time to fix those soon

@fangpenlin fangpenlin force-pushed the bugfix-18945-inverted-sticky-footer branch from 01d4cfc to 593585a Compare November 2, 2024 04:05
@fangpenlin
Copy link
Author

Hi @migueldaipre, @cortinico and @cipolleschi, sorry about that. I updated the branch and ran test locally and it seems to be passing now. As for failing linter action, I didn't see anything from the messages look like causing by my changes. Is it suppose to fail regardless? If so, can you please help me trigger the CI action again? Thank you so much 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SectionList][inverted] SectionList headers are sticky-at-the-top-footers if the list is inverted
2 participants
@fangpenlin @facebook-github-bot