Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude generation of app-defined components from RCTThirdPartyFabricComponentsProvider #47176

Closed
wants to merge 1 commit into from

Commits on Oct 23, 2024

  1. Exclude generation of app-defined components from RCTThirdPartyFabric…

    …ComponentsProvider
    
    Summary:
    While writing the guide for the New Architecture, we realized that we need to exclude the generation of the Cls function in the RCTThirdPartyFabricComponentsProvider for components defined in the app.
    
    This is needed because a component that is defined in the app will have those function defined in the app project. However, the RCTThirdPartyFabricComponentsProvider is generated in Fabric, inside the Pods project.
    
    The pod project needs to build in isolation from the app and cocoapods then link the app to the pods project. But the compilation of the pods project fails if one of the symbol needed by the pods lives in the app.
    
    By disabling the generation of that function in th RCTThirdPartyFabricComponentsProvider, we can successfully build the app.
    
    The downside is that the user needs to register the component manually, but this is not an issue because if they are writing a component in the app space, they have all the information tomanually register it in the AppDelegate
    
    ## Changelog
    [iOS][Fixed] - Do not generate the ComponentCls function in the RCTThirdPartyFabricComponentsProvider for components deined in the app.
    
    Differential Revision: D64739896
    cipolleschi authored and facebook-github-bot committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e2b8a44 View commit details
    Browse the repository at this point in the history