-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Android): add support for invert colors check on android accessibility #47341
Conversation
Hi @oddlyspaced! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Hello all, this is my first PR here. If there is something that can be improved please let me know. I've triaged a list of small implementations that are missing on android regarding accessibility and aim to add support for all of them. This is a first for the same. |
I have now signed the CLA 👍 |
@cortinico apologies if the tag is unnecessary, it is my first time raising a PR here, but can you let me know if all is well here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for it inside RNTester?
packages/react-native/Libraries/Components/AccessibilityInfo/AccessibilityInfo.js
Outdated
Show resolved
Hide resolved
Sure 👍🏾 |
@cortinico done. I've moved the test to common scope. On running jest locally, this test seemed to pass well, however some unrelated tests were failing. 🤔 please lmk if something needs to be updated. |
fixed an incorrect usage of content resolver ^ |
@cortinico sorry for the tag again, please lmk if all is good now 🙏🏾 |
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Folks, Is there anything remaining from my end? |
This pull request was successfully merged by @oddlyspaced in cc1d285 When will my fix make it into a release? | How to file a pick request? |
Summary:
This PR provides a fix for the long existing issue of missing check for invert color in accessibility options on Android.
Reference Issue : #30870
Changelog:
Pick one each for the category and type tags:
[ANDROID] [FIXED] - Missing isInvertColorsEnabled implementation for Android
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
Test Plan:
Tested on OnePlus 12 with Android 14 and Pixel 6 with Android 15. The try catch exists because in some cases if the switch hasn't been toggled before the android system raises the missing settings exception.