Exclude $$PropSetter classes from public API #47432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65488026 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 5, 2024
Summary: In this diff we are excluding the $$PropSetter classes from public API, we do this by adding the UnstableReactNativeAPI annotation on all $$PropSetter classes changelog: [internal] internal Reviewed By: cortinico Differential Revision: D65488026
mdvacca
force-pushed
the
export-D65488026
branch
from
c80e451 to
b65ad3a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65488026 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 5, 2024
Summary: Pull Request resolved: facebook#47432 In this diff we are excluding the $$PropSetter classes from public API, we do this by adding the UnstableReactNativeAPI annotation on all $$PropSetter classes changelog: [internal] internal Reviewed By: cortinico Differential Revision: D65488026
|
This pull request was exported from Phabricator. Differential Revision: D65488026 |
mdvacca
force-pushed
the
export-D65488026
branch
from
b65ad3a to
1735ea6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65488026 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 5, 2024
Summary: In this diff we are excluding the $$PropSetter classes from public API, we do this by adding the UnstableReactNativeAPI annotation on all $$PropSetter classes changelog: [internal] internal Reviewed By: cortinico Differential Revision: D65488026
mdvacca
force-pushed
the
export-D65488026
branch
from
1735ea6 to
fce3afa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65488026 |
mdvacca
force-pushed
the
export-D65488026
branch
from
fce3afa to
46579c8
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 6, 2024
Summary: In this diff we are excluding the $$PropSetter classes from public API, we do this by adding the UnstableReactNativeAPI annotation on all $$PropSetter classes changelog: [internal] internal Reviewed By: cortinico Differential Revision: D65488026
|
This pull request was exported from Phabricator. Differential Revision: D65488026 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 6, 2024
Summary: In this diff we are excluding the $$PropSetter classes from public API, we do this by adding the UnstableReactNativeAPI annotation on all $$PropSetter classes changelog: [internal] internal Reviewed By: cortinico Differential Revision: D65488026
mdvacca
force-pushed
the
export-D65488026
branch
from
46579c8 to
3269c20
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65488026 |
Summary: In this diff we are excluding the $$PropSetter classes from public API, we do this by adding the UnstableReactNativeAPI annotation on all $$PropSetter classes changelog: [internal] internal Reviewed By: cortinico Differential Revision: D65488026
mdvacca
force-pushed
the
export-D65488026
branch
from
3269c20 to
8c6d530
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65488026 |
|
This pull request has been merged in 5c3c152. |
|
This pull request was successfully merged by @mdvacca in 5c3c152 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff we are excluding the $$PropSetter classes from public API, we do this by adding the UnstableReactNativeAPI annotation on all $$PropSetter classes
changelog: [internal] internal
Reviewed By: cortinico
Differential Revision: D65488026