'[skip ci] [RN][Android] Internalize Continuation #47540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65738329 |
Summary: I'm updating KDoc for ReactHost.destroy() methods to warn about potential deadlock when waiting for completion Differential Revision: D65734396
Summary: Migrate ExecutorException to kotlin changelog: [internal] internal Differential Revision: D65738325
Summary: Migrate Continuation interface to kotlin changelog: [internal] internal Differential Revision: D65738326
Summary: Pull Request resolved: facebook#47540 Continuation is only used inside RN, we should make it internal changelog: [Android][Chnaged] Reduce visibility of Continuation to internal, although this interface wasn't being exposed in any public API Differential Revision: D65738329
mdvacca
force-pushed
the
export-D65738329
branch
from
f7b0d17 to
d7b218e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65738329 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65738329 |
|
This pull request has been merged in 7b21b9e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Continuation is only used inside RN, we should make it internal
changelog: [Android][Chnaged] Reduce visibility of Continuation to internal, although this interface wasn'''t being exposed in any public API
Differential Revision: D65738329