Share common ShadowNode functionality in BaseTextInputShadowNode for Android #48165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 7, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
88fab82 to
f8a17b4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 7, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
f8a17b4 to
4c0a959
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 7, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
4c0a959 to
be7b8b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
force-pushed
the
export-D66914447
branch
from
be7b8b7 to
6fdc784
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 8, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 9, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
6fdc784 to
09a3b45
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 9, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
09a3b45 to
f9eaf6d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 9, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
f9eaf6d to
f700c42
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 10, 2024
…Android (facebook#48165) Summary: Pull Request resolved: facebook#48165 [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
force-pushed
the
export-D66914447
branch
from
f700c42 to
b4c6f09
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…BaseTextInputShadowNode for Android (facebook#48582) Summary: [Changelog] [Internal] - Preparation for sharing common ShadowNode functionality in BaseTextInputShadowNode for Android As a preparation for facebook#48165 this change aligns the order of methods between: - BaseTextInputShadowNode.h - AndroidTextInputShadowNode.h to make it easier for future changes to look at the delta between both implementations. The goal is land facebook#48582 which aligns the RN iOS and RN Android implementation Differential Revision: D68001423
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…lder string with AndroidTextInputShadowNode (facebook#48584) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to calculate placeholder string with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004218
christophpurrer
force-pushed
the
export-D66914447
branch
from
700a4a2 to
7587ce9
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…ng with AndroidTextInputShadowNode Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…Android (facebook#48165) Summary: [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…putShadowNode for Android (facebook#48582) Summary: [Changelog] [Internal] - Preparation for sharing common ShadowNode functionality in BaseTextInputShadowNode for Android As a preparation for facebook#48165 this change aligns the order of methods between: - BaseTextInputShadowNode.h - AndroidTextInputShadowNode.h to make it easier for future changes to look at the delta between both implementations. The goal is land facebook#48582 which aligns the RN iOS and RN Android implementation Differential Revision: D68001423
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…g with AndroidTextInputShadowNode (facebook#48584) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to calculate placeholder string with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004218
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 10, 2025
…droidTextInputShadowNode Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
…putShadowNode for Android (#48582) Summary: Pull Request resolved: #48582 [Changelog] [Internal] - Preparation for sharing common ShadowNode functionality in BaseTextInputShadowNode for Android As a preparation for #48165 this change aligns the order of methods between: - BaseTextInputShadowNode.h - AndroidTextInputShadowNode.h to make it easier for future changes to look at the delta between both implementations. The goal is land #48582 which aligns the RN iOS and RN Android implementation Reviewed By: NickGerleman Differential Revision: D68001423 fbshipit-source-id: 5a5efa6542de676bd175744e7313c2b819e67f11
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
…g with AndroidTextInputShadowNode (#48584) Summary: Pull Request resolved: #48584 [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to calculate placeholder string with AndroidTextInputShadowNode As a preparation for #48165 this aligns the implementation of those 2 methods Reviewed By: NickGerleman Differential Revision: D68004218 fbshipit-source-id: 722a33bb2665c59347ef1b0cd8ed7b35a05b2113
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 15, 2025
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 15, 2025
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 15, 2025
…droidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 15, 2025
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
force-pushed
the
export-D66914447
branch
from
7587ce9 to
af23278
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 15, 2025
…ng with AndroidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 15, 2025
…Android (facebook#48165) Summary: [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
…ng with AndroidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
…Android (facebook#48165) Summary: [Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation Differential Revision: D66914447
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 16, 2025
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 16, 2025
…tateIfNeeded with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68004755
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 16, 2025
…droidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
christophpurrer
force-pushed
the
export-D66914447
branch
from
af23278 to
238dc1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66914447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog] [Internal] - Share common ShadowNode functionality in BaseTextInputShadowNode for Android
This change deletes the current Android implementation - but copies over 'relevant' code into the new shared implementation
Differential Revision: D66914447