Fix hitTest for auto #501
Closed
Fix hitTest for auto #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
boopathi
commented
Mar 30, 2015
boopathi
commented
- Returns matching subview hitTest or super hitTest if no match found. Should fix TextInput inside View doesn't work #99 .
| @@ -114,26 +114,35 @@ - (void)setPointerEvents:(RCTPointerEvents)pointerEvents | |||
| } | |||
| } | |||
|
|
|||
| - (UIView *)getSubviewHitTestView:(CGPoint)point withEvent:(UIEvent *)event | |||
There was a problem hiding this comment.
Can you make it a C function? Pass the UIView * as a parameter.
boopathi
force-pushed
the
fix-hitTestAuto
branch
2 times, most recently
from
326f7e6 to
df15a3f
Compare
| @@ -16,6 +16,20 @@ | |||
|
|
|||
| static const RCTBorderSide RCTBorderSideCount = 4; | |||
|
|
|||
| UIView* getSubviewHitTestView(UIView *view, CGPoint point, UIEvent *event) | |||
There was a problem hiding this comment.
I would give it a better name, and make it a static inline function.
NS_INLINE UIView *RCTViewHitTest(UIView *view, CGPoint point, UIEvent *event)
…if no match found
boopathi
force-pushed
the
fix-hitTestAuto
branch
from
df15a3f to
643087b
Compare
|
Thanks for that, your diff has already been merged internally and should be out on the next sync. |
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 13, 2015
Summary: - Returns matching subview hitTest or super hitTest if no match found. Should fix facebook#99 . Closes facebook#501 Github Author: Boopathi Rajaa <me@boopathi.in> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 14, 2015
Summary: - Returns matching subview hitTest or super hitTest if no match found. Should fix facebook#99 . Closes facebook#501 Github Author: Boopathi Rajaa <me@boopathi.in> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 15, 2015
Summary: - Returns matching subview hitTest or super hitTest if no match found. Should fix facebook#99 . Closes facebook#501 Github Author: Boopathi Rajaa <me@boopathi.in> Test Plan: Imported from GitHub, without a `Test Plan:` line.
jfrolich
pushed a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.