Adding scrollWithoutAnimationTo method for ScrollViews
#509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing the consensus approach from the comments on this PR: #486 We use a boolean flag in the Obj-C code to determine whether to animate or not, and then provide two public JS functions that call the Obj-C with or without the flag.
|
Merged internally and synced. |
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 13, 2015
Summary: Implementing the consensus approach from the comments on this PR: facebook#486 We use a boolean flag in the Obj-C code to determine whether to animate or not, and then provide two public JS functions that call the Obj-C with or without the flag. Closes facebook#509 Github Author: Charlie Cheever <ccheever@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 14, 2015
Summary: Implementing the consensus approach from the comments on this PR: facebook#486 We use a boolean flag in the Obj-C code to determine whether to animate or not, and then provide two public JS functions that call the Obj-C with or without the flag. Closes facebook#509 Github Author: Charlie Cheever <ccheever@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 15, 2015
Summary: Implementing the consensus approach from the comments on this PR: facebook#486 We use a boolean flag in the Obj-C code to determine whether to animate or not, and then provide two public JS functions that call the Obj-C with or without the flag. Closes facebook#509 Github Author: Charlie Cheever <ccheever@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
jfrolich
pushed a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
I deleted all the style docs as I am working on it & don't want to keep it in sync ftm. Closes facebook#503
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Jul 21, 2020
* Fix onFocus/onBlur event bubbling (facebook#506) * Update scripts to publish react-native-macos-init * Clean up merge markers * Restored ios:macos RNTester parity except for InputAccessoryView. * Revert "Restored ios:macos RNTester parity except for InputAccessoryView." This reverts commit 5a67ae0. * Remove unnecessary android builds and tar file upload. * Fix onFocus/onBlur View events to properly bubble. * The Text component can also be selectable={true} and needs the same focus/blur event triggering as View. Co-authored-by: React-Native Bot <53619745+rnbot@users.noreply.github.com> * Added new RCTFocusChangeEvent to static xcodeproj's * Change vmImage to ubuntu-latest for Android builds. Co-authored-by: React-Native Bot <53619745+rnbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the consensus approach from the comments on
this PR:
#486
We use a boolean flag in the Obj-C code to determine whether
to animate or not, and then provide two public JS functions
that call the Obj-C with or without the flag.