-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow View containers to specify custom measure functions #5148
Conversation
…e in ViewGroupManager
Hey @obipawan, what's the motivation for this? |
Hey @mkonicek |
Why can you not provide a custom LayoutShadowNode by extending ViewGroupManager? |
I don't see this change being necessary to support the use case you're describing. If you want your view group manager to use custom class as a shadow node you can simply override |
Hey @kmagiera It's possible to override |
@obipawan Are you sure that is the case here? The return type on |
This PR allows
ViewManagers
that are containers (extendingViewGroupManager
) to specify it's customCSSNode.MeasureFunction
.ViewManagers
that don't need to specify this can extendSimpleViewGroupManager
instead