-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove false annotation #592
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thanks! This is the code that renders this element in the docs. If you can come up with a way to annotate those it would be great :) |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Summary: I'd love to add annotations letting people know that this function and a few others take `SyntheticEvent`s but that may be inconsistent with the rest of the docs. For now, this particular annotation should be removed Closes facebook#592 Github Author: Will Piers <wpiers@rallydev.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: I'd love to add annotations letting people know that this function and a few others take `SyntheticEvent`s but that may be inconsistent with the rest of the docs. For now, this particular annotation should be removed Closes facebook#592 Github Author: Will Piers <wpiers@rallydev.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
* Fix passthrough props on TouchableWithoutFeedback Most of the macOS-specific props should be passed through, but acceptsKeyboardFocus and enableFocusRing should default to true like the other Touchable components. * Update snapshots with TouchableWithoutFeedback fix
* Fix passthrough props on TouchableWithoutFeedback Most of the macOS-specific props should be passed through, but acceptsKeyboardFocus and enableFocusRing should default to true like the other Touchable components. * Update snapshots with TouchableWithoutFeedback fix
I'd love to add annotations letting people know that this function and a few others take
SyntheticEvent
s but that may be inconsistent with the rest of the docs. For now, this particular annotation should be removed