Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify use of password and secureTextEntry for TextInput #622

Closed
wants to merge 1 commit into from
Closed

unify use of password and secureTextEntry for TextInput #622

wants to merge 1 commit into from

Conversation

willpiers
Copy link
Contributor

Currently, the documentation shows both password and secureTextEntry as props for TextInput. However, the password prop is only passed to the Android component, so it does not work as expected for iOS developers. This PR prefers password over secureTextEntry but won't break anybody's code.

@zachwill
Copy link

zachwill commented Apr 3, 2015

👍

@mkonicek
Copy link
Contributor

mkonicek commented Apr 3, 2015

Looks good!
@vjeux, @sahrens does React Native aim for backwards compatibility before version 1.0? If not, you could simply do secureTextEntry={this.props.password}.

@willpiers
Copy link
Contributor Author

Good question @mkonicek - that would be nice if we could just standardize on password. @vjeux @sahrens what do you think?

@vjeux
Copy link
Contributor

vjeux commented Apr 6, 2015

Many things here:

  1. What is the web naming for this attribute if it even exists?
  2. Have those two attributes exactly the same behavior?
  3. We want to split this into TextInputIOS and TextInputAndroid because they don't share the exact set of props. Maybe add a TextInput that's a lowest common denominator

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2015
@brentvatne
Copy link
Collaborator

@vjeux - re: point 1, it is type="password"

@vjeux vjeux closed this in 5eccf58 Apr 13, 2015
vjeux pushed a commit to vjeux/react-native that referenced this pull request Apr 14, 2015
unify use of password and secureTextEntry for TextInput
18e8e87 
Summary:
Currently, the documentation shows both `password` and `secureTextEntry` as props for TextInput. However, the `password` prop is only passed to the Android component, so it does not work as expected for iOS developers. This PR prefers `password` over `secureTextEntry` but won't break anybody's code.
Closes facebook#622
Github Author: Will Piers <wpiers@rallydev.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux pushed a commit to vjeux/react-native that referenced this pull request Apr 15, 2015
unify use of password and secureTextEntry for TextInput
c831328 
Summary:
Currently, the documentation shows both `password` and `secureTextEntry` as props for TextInput. However, the `password` prop is only passed to the Android component, so it does not work as expected for iOS developers. This PR prefers `password` over `secureTextEntry` but won't break anybody's code.
Closes facebook#622
Github Author: Will Piers <wpiers@rallydev.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
ayushjainrksh referenced this pull request in MLH-Fellowship/react-native Jul 2, 2020
@shawnkoon @hramos
Fix small bug in ReadMe doc and add consistent periods. (#622)
5d733b0
This was referenced Sep 11, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@willpiers @zachwill @mkonicek @vjeux @brentvatne @facebook-github-bot