Remove Releases tab from header #6388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request moves the content of the Releases tab to the version number next to the title. With the search bar, the header was getting too crowded. I've cleaned up the search style a bit and made it look like the React one (with the background color). I've also improved the styling of the versions page
| @@ -86,7 +86,7 @@ var Site = React.createClass({ | |||
| apiKey: '2c98749b4a1e588efec53b2acec13025', | |||
| indexName: 'react-native-versions', | |||
| inputSelector: '#algolia-doc-search', | |||
| algoliaOptions: { facetFilters: [ "tags:${algoliaVersion}" ] } | |||
| algoliaOptions: { facetFilters: [ "tags:${algoliaVersion}" ], hitsPerPage: 5 } | |||
There was a problem hiding this comment.
This is a temporary fix until they fix the bug on their end
|
By analyzing the blame information on this pull request, we identified @skevy, @bestander and @vjeux to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
| width: 240px; | ||
| } | ||
|
|
||
| @media screen and (max-width: 1085px) { |
There was a problem hiding this comment.
I removed all the size specific versions, not very useful
|
Love it! |
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the content of the Releases tab to the version number next to the title. With the search bar, the header was getting too crowded.