-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document ListView.DataSource #410 #7193
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By analyzing the blame information on this pull request, we identified @janicduplessis and @pglotov to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
labels
Apr 24, 2016
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
Import Started
This pull request has been imported. This does not imply the PR has been approved.
and removed
GH Review: review-needed
labels
Apr 24, 2016
Thanks for importing. If you are an FB employee go to Phabricator to review. |
@satya164 looks like we have an unofficial Triage going on today 🎱 |
@grabbou Haha, I couldn't participate in the last triage, so trying to make up to it ;p |
Same :D |
ghost
closed this
in
Apr 24, 2016
7102fd0
ptmt
pushed a commit
to ptmt/react-native
that referenced
this pull request
May 9, 2016
Summary:Fixes facebook#410 Closes facebook#7193 Differential Revision: D3217718 fb-gh-sync-id: c05c9e3d67863c064f8e1102090614c6ba7e3127 fbshipit-source-id: c05c9e3d67863c064f8e1102090614c6ba7e3127
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:Fixes facebook#410 Closes facebook#7193 Differential Revision: D3217718 fb-gh-sync-id: c05c9e3d67863c064f8e1102090614c6ba7e3127 fbshipit-source-id: c05c9e3d67863c064f8e1102090614c6ba7e3127
samerce
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary:Fixes facebook#410 Closes facebook#7193 Differential Revision: D3217718 fb-gh-sync-id: c05c9e3d67863c064f8e1102090614c6ba7e3127 fbshipit-source-id: c05c9e3d67863c064f8e1102090614c6ba7e3127
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Import Started
This pull request has been imported. This does not imply the PR has been approved.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #410
Test plan:
Run locally, go to
ListView
docs and click one of the anchors.