Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ListView.DataSource #410 #7193

Closed
wants to merge 2 commits into from
Closed

Document ListView.DataSource #410 #7193

wants to merge 2 commits into from

Conversation

grabbou
Copy link
Contributor

@grabbou grabbou commented Apr 24, 2016

Fixes #410

Test plan:
Run locally, go to ListView docs and click one of the anchors.

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @janicduplessis and @pglotov to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Apr 24, 2016
@grabbou grabbou changed the title Feat/list view ds docs Document ListView.DataSource #410 Apr 24, 2016
@satya164
Copy link
Contributor

@facebook-github-bot shipit

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Apr 24, 2016
@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@grabbou
Copy link
Contributor Author

grabbou commented Apr 24, 2016

@satya164 looks like we have an unofficial Triage going on today 🎱

@satya164
Copy link
Contributor

@grabbou Haha, I couldn't participate in the last triage, so trying to make up to it ;p

@grabbou
Copy link
Contributor Author

grabbou commented Apr 24, 2016

Same :D

@ghost ghost closed this in 7102fd0 Apr 24, 2016
ptmt pushed a commit to ptmt/react-native that referenced this pull request May 9, 2016
Summary:Fixes facebook#410
Closes facebook#7193

Differential Revision: D3217718

fb-gh-sync-id: c05c9e3d67863c064f8e1102090614c6ba7e3127
fbshipit-source-id: c05c9e3d67863c064f8e1102090614c6ba7e3127
zebulgar pushed a commit to nightingale/react-native that referenced this pull request Jun 18, 2016
Summary:Fixes facebook#410
Closes facebook#7193

Differential Revision: D3217718

fb-gh-sync-id: c05c9e3d67863c064f8e1102090614c6ba7e3127
fbshipit-source-id: c05c9e3d67863c064f8e1102090614c6ba7e3127
samerce pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
Summary:Fixes facebook#410
Closes facebook#7193

Differential Revision: D3217718

fb-gh-sync-id: c05c9e3d67863c064f8e1102090614c6ba7e3127
fbshipit-source-id: c05c9e3d67863c064f8e1102090614c6ba7e3127
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants