Tweaked how the TextInput works in order to fix autocorrect. #7651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @Bhullnatik and @nicklockwood to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
|
@mpretty-homepass updated the pull request. |
|
@mpretty-homepass updated the pull request. |
|
@mpretty-homepass updated the pull request. |
|
PR #7676 offers an alternative approach for fixing this. |
|
Closing in favour of 26aa27d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first attempt at resolving issue #7496 (Autocorrect basically doesn't work on iOS).
This makes a fairly drastic change to how the TextField handles input, this change makes the TextInput reject changes in native by default, the change event is sent to RN which then calls back to native and directly set's the text.
We will probably need to make similar changes on Android since it is a behavioural change but I haven't just yet as I'm not sure if this is the behaviour we want from the TextInput.
Open to input - let me know if anyone can think of alternate solutions.