Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New global property are no longer writable #7658

Closed
wants to merge 2 commits into from

Conversation

marclaval-watcher
Copy link

Likely introduced by 9a3a082
/cc @lexs

@ghost
Copy link

ghost commented May 20, 2016

By analyzing the blame information on this pull request, we identified @lexs and @javache to be potential reviewers.

@ghost
Copy link

ghost commented May 20, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

@marclaval updated the pull request.

@ghost
Copy link

ghost commented May 23, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2016
@janicduplessis
Copy link
Contributor

Thanks @marclaval, I see that there is another PR that tries to fix this problem and is getting merged atm. Let's close this one in favor of #7704.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants