Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TextInput autocorrect (#7496) #7676

Closed
wants to merge 1 commit into from
Closed

Fix TextInput autocorrect (#7496) #7676

wants to merge 1 commit into from
+7 −1

Commits on May 22, 2016

  1. Fix TextInput autocorrect (facebook#7496) 

    TextInput autocorrect was broken by a change to batch event handling in React Native:
facebook/react@9f11f8c

This fix uses the same approach as
facebook@0cd2904

The problem is that TextInput's _onChange handler relied on this.props.value
being updated synchronously when calling this.props.onChangeText(text). However,
this assumption was broken when React Native event handling started being batched.

The fix is to move the code that relies on this.props.value being up-to-date to
componentDidUpdate.
    Adam Comella committed May 22, 2016
    Configuration menu
    Copy the full SHA
    a801020 View commit details
    Browse the repository at this point in the history